Bug 96040

Summary: Web Inspector: Allow extensions to open FilteredItemSelectorDialog
Product: WebKit Reporter: johnjbarton <johnjbarton>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: apavlov, burg, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
rebase and fix formatting webkit.review.bot: commit-queue-

Description johnjbarton 2012-09-06 16:46:26 PDT 
The FilteredItemSelectorDialog (bound to eg control + o to open files) is a nice, general purpose list selection widget. By exposing it to WebInspector extensions, the extensions can be more effective, feel more integrated with the WebInspector, and users can adapt to extensions more quickly. 

Such an extension could have many uses, eg "find a CSS selector", "find a JS identifier", "find localized strings", "find test cases on my special test server", etc.
Comment 1 johnjbarton 2012-09-06 17:06:01 PDT 
Created attachment 162620 [details]
Patch
Comment 2 johnjbarton 2012-09-06 17:07:17 PDT 
Please give feedback on the concept and API first. I guess this will need to be behind some experimental flag.
Comment 3 WebKit Review Bot 2012-09-07 13:57:06 PDT 
Comment on attachment 162620 [details]
Patch

Attachment 162620 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13778738

New failing tests:
inspector/extensions/extensions-panel.html
Comment 4 johnjbarton 2012-09-11 09:53:51 PDT 
Created attachment 163388 [details]
rebase and fix formatting
Comment 5 WebKit Review Bot 2012-09-12 01:14:02 PDT 
Comment on attachment 163388 [details]
rebase and fix formatting

Attachment 163388 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13825524

New failing tests:
inspector/extensions/extensions-panel.html
Comment 6 Pavel Feldman 2012-09-21 03:09:52 PDT 
Do we have use cases for this API? Did any of the extensions try to create such a UI on their panel? I wouldn't want to expose provisional extensions APIs.
Comment 7 Pavel Feldman 2012-09-21 03:10:11 PDT 
Comment on attachment 163388 [details]
rebase and fix formatting

Clearing r? while we are figuring out whether this is needed.
Comment 8 johnjbarton 2012-09-21 07:34:11 PDT 
I'm using it in my extension, to load files into an editor in conjunction with Resource get/setContent.