Bug 96017 – Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView

[Simon Fraser (smfr)]

Created attachment 162574 [details]
Patch

[James Robinson]

Comment on attachment 162574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162574&action=review

> Source/WebCore/page/FrameView.h:-200
> -    // This includes position:fixed and sticky objects.

This comment was nice - I'm not sure if "viewport constrained" has quite caught on enough for everyone to know that it includes position:fixed and position:sticky

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/127783

[Csaba Osztrogonác]

(In reply to comment #3)
> http://trac.webkit.org/changeset/127783

And WK2 buildfix landed in https://trac.webkit.org/changeset/127816

Will you wait for the EWS and/or watch the buildbots next time, please?

Breaking the build and leaving it broken for 7 hours / 32 revisions isn't
too friendly ... I don't have to fix the build instead of you ... But 
you have to guarantee that your change builds everywhere. I might 
rollout the patch next time and let you fix it yourself.


Plese rescpect the following rule in the future:
https://www.webkit.org/coding/contributing.html
"Keeping the tree green
...
Your change must at least compile on all platforms."

[Simon Fraser (smfr)]

Thanks for the fix, Ossy. Sorry for the bustage.