Bug 96007

Summary: [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, dglazkov, enne, fishd, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 96006    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
for ews none

James Robinson
Reported 2012-09-06 12:27:15 PDT
[chromium] Use WebCompositorSupport functions instead of WebCompositor statics
Attachments
Patch (44.64 KB, patch)
2012-09-06 12:28 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
for ews (44.66 KB, patch)
2012-09-06 13:53 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-09-06 12:28:57 PDT
Created attachment 162555 [details] Patch
James Robinson
Comment 2 2012-09-06 12:29:24 PDT
Follow-up to https://bugs.webkit.org/show_bug.cgi?id=95785.
WebKit Review Bot
Comment 3 2012-09-06 12:30:42 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Peter Beverloo (cr-android ews)
Comment 4 2012-09-06 13:25:08 PDT
Comment on attachment 162555 [details] Patch Attachment 162555 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13777289
Adrienne Walker
Comment 5 2012-09-06 13:38:47 PDT
Comment on attachment 162555 [details] Patch R=me. Sounds fine to me, assuming you fix the ews issue.
James Robinson
Comment 6 2012-09-06 13:48:40 PDT
This won't work in a WebKit checkout until the roll in https://bugs.webkit.org/show_bug.cgi?id=96006 lands. Looks like cr-android failed due to a unit test behind an #ifdef, easy to fix (just add the namespace).
James Robinson
Comment 7 2012-09-06 13:53:51 PDT
Created attachment 162576 [details] for ews
James Robinson
Comment 8 2012-09-06 16:17:18 PDT
Committed r127794: <http://trac.webkit.org/changeset/127794>
Note You need to log in before you can comment on or make changes to this bug.