Summary: | Make RenderingAllInOne.cpp usable for ports other than Apple/Win | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||||
Component: | New Bugs | Assignee: | Simon Hausmann <hausmann> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | CC: | eric, jberlin, ossy, rniwa, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Hausmann
2012-09-06 11:04:02 PDT
Created attachment 162539 [details]
Patch
Created attachment 162540 [details]
Patch
Rebased to ToT
An alternative is to put #ifdefs into the AllInOne cpp files, although that would complicate things for the Qt build system. Of course if those files are not meant to be shareable across ports, then that's also okay, wouldn't be a big deal I think. Reverted r129248 for reason: Broke win build Committed r129249: <http://trac.webkit.org/changeset/129249> |