Bug 96000

Summary: Make RenderingAllInOne.cpp usable for ports other than Apple/Win
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: eric, jberlin, ossy, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

Simon Hausmann
Reported 2012-09-06 11:04:02 PDT
Make RenderingAllInOne.cpp usable for ports other than Apple/Win
Attachments
Patch (3.54 KB, patch)
2012-09-06 11:06 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (3.50 KB, patch)
2012-09-06 11:10 PDT, Simon Hausmann 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-09-06 11:06:03 PDT
Created attachment 162539 [details] Patch
Simon Hausmann
Comment 2 2012-09-06 11:10:32 PDT
Created attachment 162540 [details] Patch Rebased to ToT
Simon Hausmann
Comment 3 2012-09-06 11:13:38 PDT
An alternative is to put #ifdefs into the AllInOne cpp files, although that would complicate things for the Qt build system. Of course if those files are not meant to be shareable across ports, then that's also okay, wouldn't be a big deal I think.
Simon Hausmann
Comment 4 2012-09-21 13:16:27 PDT
Reverted r129248 for reason: Broke win build Committed r129249: <http://trac.webkit.org/changeset/129249>
Csaba Osztrogonác
Comment 5 2015-02-26 04:45:01 PST
*** This bug has been marked as a duplicate of bug 99579 ***
Note You need to log in before you can comment on or make changes to this bug.