Bug 95993

Summary: [BlackBerry] Add custom data-blackberry-webworks-context attribute.
Product: WebKit Reporter: gmak
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch with commit log none

gmak
Reported 2012-09-06 10:15:05 PDT
Check for data-blackberry-webworks-context when getting context and add the value to the context object
Attachments
patch with commit log (4.66 KB, patch)
2012-09-06 10:24 PDT, gmak 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
gmak
Comment 1 2012-09-06 10:24:03 PDT
Created attachment 162535 [details] patch with commit log
Rob Buis
Comment 2 2012-09-06 10:30:30 PDT
Comment on attachment 162535 [details] patch with commit log View in context: https://bugs.webkit.org/attachment.cgi?id=162535&action=review Looks good. > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:119 > +WTF::String webWorksContext(const WebCore::Element* element) You should not need WTF:: nor WebCore:: here. But we can fix that later wince we already have WTF usage in this file.
WebKit Review Bot
Comment 3 2012-09-06 14:00:21 PDT
Comment on attachment 162535 [details] patch with commit log Clearing flags on attachment: 162535 Committed r127782: <http://trac.webkit.org/changeset/127782>
WebKit Review Bot
Comment 4 2012-09-06 14:00:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.