Bug 95993 - [BlackBerry] Add custom data-blackberry-webworks-context attribute.
Summary: [BlackBerry] Add custom data-blackberry-webworks-context attribute.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 10:15 PDT by gmak
Modified: 2012-09-06 14:00 PDT (History)
3 users (show)

See Also:


Attachments
patch with commit log (4.66 KB, patch)
2012-09-06 10:24 PDT, gmak
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gmak 2012-09-06 10:15:05 PDT
Check for data-blackberry-webworks-context  when getting context and add the value to the context object
Comment 1 gmak 2012-09-06 10:24:03 PDT
Created attachment 162535 [details]
patch with commit log
Comment 2 Rob Buis 2012-09-06 10:30:30 PDT
Comment on attachment 162535 [details]
patch with commit log

View in context: https://bugs.webkit.org/attachment.cgi?id=162535&action=review

Looks good.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:119
> +WTF::String webWorksContext(const WebCore::Element* element)

You should not need WTF:: nor WebCore:: here. But we can fix that later wince we already have WTF usage in this file.
Comment 3 WebKit Review Bot 2012-09-06 14:00:21 PDT
Comment on attachment 162535 [details]
patch with commit log

Clearing flags on attachment: 162535

Committed r127782: <http://trac.webkit.org/changeset/127782>
Comment 4 WebKit Review Bot 2012-09-06 14:00:24 PDT
All reviewed patches have been landed.  Closing bug.