Bug 95990

Summary:

[EFL][WK2] Build warning : fix warning about extended initializer on EWK2UnitTestBase.cpp.

Product:

WebKit

Reporter:

Byungwoo Lee <bw80.lee>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Byungwoo Lee

Reported 2012-09-06 09:14:06 PDT

There is a warning on EWK2UnitTestBase.cpp.

Attachments
Patch (1.98 KB, patch) 2012-09-06 09:20 PDT, Byungwoo Lee	no flags	Details Formatted Diff Diff
Patch (1.99 KB, patch) 2012-09-06 23:18 PDT, Byungwoo Lee	no flags	Details Formatted Diff Diff
Patch (1.99 KB, patch) 2012-09-07 01:40 PDT, Byungwoo Lee	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Byungwoo Lee

Comment 1 2012-09-06 09:17:57 PDT

Warning message : warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x [enabled by default]

Byungwoo Lee

Comment 2 2012-09-06 09:20:57 PDT

Created attachment 162522 [details] Patch

Gyuyoung Kim

Comment 3 2012-09-06 22:47:17 PDT

Comment on attachment 162522 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162522&action=review > Source/WebKit2/ChangeLog:3 > + Build warning : fix warning about extended initializer lists on EWK2UnitTestBase.cpp. Good to add [EFL][WK2]

Byungwoo Lee

Comment 4 2012-09-06 23:18:07 PDT

Created attachment 162680 [details] Patch

Ryuan Choi

Comment 5 2012-09-06 23:25:30 PDT

Comment on attachment 162680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162680&action=review > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:44 > + static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View"); > + return ewkViewClass; Did you test whether this is fine although test cases does not clear the methods ?

Byungwoo Lee

Comment 6 2012-09-07 01:01:17 PDT

(In reply to comment #5) > (From update of attachment 162680 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162680&action=review > > > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:44 > > + static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View"); > > + return ewkViewClass; > > Did you test whether this is fine although test cases does not clear the methods ? It's a good point. There was no regression with current test case. But there can be some problem because ewk2UnitTestBrowserViewSmartClass() returns reference. (The initial data can be changed.) Return by copying data will be better. Thanks for pointing this.

Byungwoo Lee

Comment 7 2012-09-07 01:40:28 PDT

Created attachment 162707 [details] Patch

Gyuyoung Kim

Comment 8 2012-09-07 02:02:02 PDT

Comment on attachment 162707 [details] Patch LGTM.

Gyuyoung Kim

Comment 9 2012-09-10 21:40:48 PDT

Comment on attachment 162707 [details] Patch Looks fine.

WebKit Review Bot

Comment 10 2012-09-10 22:03:34 PDT

Comment on attachment 162707 [details] Patch Clearing flags on attachment: 162707 Committed r128145: <http://trac.webkit.org/changeset/128145>

WebKit Review Bot

Comment 11 2012-09-10 22:03:38 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.