Bug 95973

Summary: [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, gyuyoung.kim, kenneth, ossy, ryuan.choi, sam, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-09-06 04:29:21 PDT
Currently EventSender in WebKitTestRunner unconditionally maps "addSelectionKey" to "Meta" modifier. This is fine on Mac but on others OSes, it should be mapped to "Control" instead. This is causing the following test cases to fail for WebKit2 on non-Mac: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html fast/forms/listbox-deselect-scroll.html fast/forms/listbox-selection.html
Attachments
Patch (5.08 KB, patch)
2012-09-06 04:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-09-06 04:38:29 PDT
Created attachment 162475 [details] Patch
Chris Dumez
Comment 2 2012-09-06 04:43:28 PDT
Adding Ossy in CC since someone may want to check if the following tests can be unskipped on Qt with this fix: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html fast/forms/listbox-deselect-scroll.html fast/forms/listbox-selection.html They are skipped in the global Skipped list, not in the WK2-specific one so I did not dare unskip them on Qt.
WebKit Review Bot
Comment 3 2012-09-06 07:35:40 PDT
Comment on attachment 162475 [details] Patch Clearing flags on attachment: 162475 Committed r127739: <http://trac.webkit.org/changeset/127739>
WebKit Review Bot
Comment 4 2012-09-06 07:35:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.