Bug 95966

Summary: Expose DOM interface for CSS Device Adaptation
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: CSSAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, dbates, donggwan.kim, gyuyoung.kim, haraken, japhet, kenneth, koivisto, laszlo.gombos, macpherson, menard, mrobinson, ojan, philn, pnormand, rakuco, webkit.review.bot, xan.lopez
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95959    
Attachments:
Description Flags
WIP
none
Patch
none
Patch none

Description Thiago Marcos P. Santos 2012-09-06 03:12:04 PDT 
Add it for both V8 and JSC.
Comment 1 Thiago Marcos P. Santos 2012-11-20 01:11:58 PST 
Created attachment 175170 [details]
WIP

Build test (with the feature enabled by default on all the ports) to see if it the EWS explodes.
Comment 2 Adam Barth 2012-11-20 01:30:48 PST 
Comment on attachment 175170 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=175170&action=review

> Source/WebKit/chromium/features.gypi:45
> -      'ENABLE_CSS_DEVICE_ADAPTATION=0',
> +      'ENABLE_CSS_DEVICE_ADAPTATION=1',

I assume you don't plan to land this part of this patch.
Comment 3 Thiago Marcos P. Santos 2012-11-20 01:40:03 PST 
Comment on attachment 175170 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=175170&action=review

>> Source/WebKit/chromium/features.gypi:45
>> +      'ENABLE_CSS_DEVICE_ADAPTATION=1',
> 
> I assume you don't plan to land this part of this patch.

Nop, it is just a build test as I wrote on the comments. Just to make sure it will work on all the ports if they want to enable it one day.
Comment 4 Thiago Marcos P. Santos 2012-11-20 08:15:02 PST 
The build test failed on GTK but I could build it locally in a clean environment. I'm guessing that GTK buildsystem might have a problem on tracking dependencies when a flag affects CSSValueKeywords.in.
Comment 5 Thiago Marcos P. Santos 2012-11-20 08:18:05 PST 
Created attachment 175225 [details]
Patch
Comment 6 Thiago Marcos P. Santos 2012-11-22 06:27:30 PST 
Created attachment 175662 [details]
Patch
Comment 7 WebKit Review Bot 2012-11-23 00:07:17 PST 
Comment on attachment 175662 [details]
Patch

Clearing flags on attachment: 175662

Committed r135564: <http://trac.webkit.org/changeset/135564>
Comment 8 WebKit Review Bot 2012-11-23 00:07:24 PST 
All reviewed patches have been landed.  Closing bug.