Bug 95960

Summary: Add feature flags for CSS Device Adaptation
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: CSSAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, donggwan.kim, gyuyoung.kim, jchaffraix, johnme, kenneth, peter, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95959    
Attachments:
Description Flags
Patch
none
Patch none

Thiago Marcos P. Santos
Reported 2012-09-06 02:55:11 PDT
Add build time option to enable/disable CSS Device Adaptation support.
Attachments
Patch (29.67 KB, patch)
2012-09-12 14:45 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Patch (30.72 KB, patch)
2012-10-26 01:18 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-09-12 14:45:17 PDT
Created attachment 163701 [details] Patch
Adam Barth
Comment 2 2012-09-13 10:13:30 PDT
How does this compile-time flag relate to ENABLE_LEGACY_VIEWPORT_ADAPTION and ENABLE_VIEWPORT ?
Thiago Marcos P. Santos
Comment 3 2012-09-13 14:16:00 PDT
(In reply to comment #2) > How does this compile-time flag relate to ENABLE_LEGACY_VIEWPORT_ADAPTION and ENABLE_VIEWPORT ? ENABLE_LEGACY_VIEWPORT_ADAPTION is unrelated. It just enables some extra keywords to the Viewport Meta Tag implementation. CSS Device Adaption shares code with Viewport Meta Tag, since it is basically a CSS equivalent of Meta Tag. The code ends at ChromeClient::dispatchViewportPropertiesDidChange which on Chromium (and AFAIK only Chromium) is protected by ENABLE_VIEWPORT. In this case, if Chromium wants CSS_DEVICE_ADAPTATION, it will also need to enable ENABLE_VIEWPORT.
Adam Barth
Comment 4 2012-09-13 15:18:50 PDT
Perhaps we should remove the ENABLE_VIEWPORT guards from dispatchViewportPropertiesDidChange in Chromium? In any case, that's an issue for a later patch. Once your implementation is complete, do you think it would make sense to merge this ENABLE with ENABLE_VIEWPORT?
Thiago Marcos P. Santos
Comment 5 2012-09-14 00:39:00 PDT
(In reply to comment #4) > Perhaps we should remove the ENABLE_VIEWPORT guards from dispatchViewportPropertiesDidChange in Chromium? In any case, that's an issue for a later patch. > > Once your implementation is complete, do you think it would make sense to merge this ENABLE with ENABLE_VIEWPORT? Makes a lot of sense. From the ChromeClient point of view, they are the same thing.
Kenneth Rohde Christiansen
Comment 6 2012-10-25 06:54:01 PDT
Comment on attachment 163701 [details] Patch r=me but only land if the feature was agreed upon on webkit-dev
Thiago Marcos P. Santos
Comment 7 2012-10-26 01:18:24 PDT
Created attachment 170845 [details] Patch
WebKit Review Bot
Comment 8 2012-10-26 03:20:47 PDT
Comment on attachment 170845 [details] Patch Clearing flags on attachment: 170845 Committed r132600: <http://trac.webkit.org/changeset/132600>
WebKit Review Bot
Comment 9 2012-10-26 03:20:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.