Bug 95938

Summary: Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, gustavo, kling, macpherson, menard, mikelawther, peter+ews, philn, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Luke Macpherson
Reported 2012-09-05 23:57:45 PDT
Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process.
Attachments
Patch (2.52 KB, patch)
2012-09-06 00:00 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.86 KB, patch)
2012-09-06 17:30 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.30 KB, patch)
2012-09-06 21:53 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-09-06 00:00:40 PDT
Created attachment 162430 [details] Patch
Peter Beverloo (cr-android ews)
Comment 2 2012-09-06 02:49:58 PDT
Comment on attachment 162430 [details] Patch Attachment 162430 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13757935
Andreas Kling
Comment 3 2012-09-06 04:48:40 PDT
Comment on attachment 162430 [details] Patch Great, r=me. Just make sure to fix the EWS warning first: CSSPrimitiveValue.cpp:368:12: error: enumeration value 'CSS_DASHBOARD_REGION' not handled in switch [-Werror=switch]
WebKit Review Bot
Comment 4 2012-09-06 14:32:48 PDT
Comment on attachment 162430 [details] Patch Attachment 162430 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13772433
Luke Macpherson
Comment 5 2012-09-06 17:30:48 PDT
Created attachment 162628 [details] Patch for landing
Early Warning System Bot
Comment 6 2012-09-06 18:29:23 PDT
Comment on attachment 162628 [details] Patch for landing Attachment 162628 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13778387
Build Bot
Comment 7 2012-09-06 18:35:37 PDT
Comment on attachment 162628 [details] Patch for landing Attachment 162628 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13765819
Gyuyoung Kim
Comment 8 2012-09-06 19:21:14 PDT
Comment on attachment 162628 [details] Patch for landing Attachment 162628 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13775551
Luke Macpherson
Comment 9 2012-09-06 21:53:10 PDT
Created attachment 162669 [details] Patch for landing
WebKit Review Bot
Comment 10 2012-09-07 00:47:55 PDT
Comment on attachment 162669 [details] Patch for landing Clearing flags on attachment: 162669 Committed r127838: <http://trac.webkit.org/changeset/127838>
WebKit Review Bot
Comment 11 2012-09-07 00:47:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.