Bug 95919

Summary: Rename the ustring() accessor to string()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: JavaScriptCoreAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Benjamin Poulain
Reported 2012-09-05 18:07:10 PDT
Something I promised to do.
Attachments
Patch (50.75 KB, patch)
2012-09-05 18:33 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (64.78 KB, patch)
2012-09-05 21:55 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch for landing (65.57 KB, patch)
2012-09-07 22:17 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-09-05 18:33:54 PDT
Created attachment 162389 [details] Patch
Gyuyoung Kim
Comment 2 2012-09-05 19:34:35 PDT
Comment on attachment 162389 [details] Patch Attachment 162389 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13765437
Gyuyoung Kim
Comment 3 2012-09-05 20:13:39 PDT
Comment on attachment 162389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162389&action=review This patch needs to be adjusted into below files in order to see green color on eflews. Tools/DumpRenderTree/efl/TestRunnerEfl.cpp Tools/DumpRenderTree/efl/WorkQueueItemEfl.cpp Tools/DumpRenderTree/efl/EventSender.cpp > Source/WebKit/efl/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). I think this description is unneeded.
Benjamin Poulain
Comment 4 2012-09-05 21:26:19 PDT
Comment on attachment 162389 [details] Patch > This patch needs to be adjusted into below files in order to see green color on eflews. > > Tools/DumpRenderTree/efl/TestRunnerEfl.cpp > Tools/DumpRenderTree/efl/WorkQueueItemEfl.cpp > Tools/DumpRenderTree/efl/EventSender.cpp Snap! I only checked under Source/
Benjamin Poulain
Comment 5 2012-09-05 21:55:44 PDT
Created attachment 162415 [details] Patch
Geoffrey Garen
Comment 6 2012-09-06 18:44:17 PDT
Comment on attachment 162415 [details] Patch rs=me
Benjamin Poulain
Comment 7 2012-09-07 22:17:36 PDT
Created attachment 162939 [details] Patch for landing
Benjamin Poulain
Comment 8 2012-09-07 22:45:57 PDT
Comment on attachment 162939 [details] Patch for landing Clearing flags on attachment: 162939 Committed r127958: <http://trac.webkit.org/changeset/127958>
Benjamin Poulain
Comment 9 2012-09-07 22:46:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.