Bug 95872

Summary: Build failure with accelerated compositing disabled
Product: WebKit Reporter: arno. <a.renevier>
Component: WebKitGTKAssignee: arno. <a.renevier>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch proposal none

arno.
Reported 2012-09-05 10:54:09 PDT
Hi, when I try to build webkit with: build-webkit --gtk --disable-accelerated-compositing the build fails with following error: ../../Source/WebCore/html/canvas/WebGLRenderingContext.cpp: In member function ‘void WebCore::WebGLRenderingContext::markContextChanged()’: ../../Source/WebCore/html/canvas/WebGLRenderingContext.cpp:606:26: error: ‘class WebCore::DrawingBuffer’ has no member named ‘markContentsChanged’ make[1]: *** [Source/WebCore/html/canvas/libWebCore_la-WebGLRenderingContext.lo] Error 1 I think the bug was introduced in #94961 I guess the problem also happens with other ports, but I'm not 100% sure of that.
Attachments
patch proposal (1.68 KB, patch)
2012-09-05 10:59 PDT, arno. 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2012-09-05 10:59:13 PDT
Created attachment 162288 [details] patch proposal
James Robinson
Comment 2 2012-09-05 11:02:37 PDT
Comment on attachment 162288 [details] patch proposal OK
WebKit Review Bot
Comment 3 2012-09-05 20:14:21 PDT
Comment on attachment 162288 [details] patch proposal Clearing flags on attachment: 162288 Committed r127683: <http://trac.webkit.org/changeset/127683>
WebKit Review Bot
Comment 4 2012-09-05 20:14:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.