Bug 95851

Summary: [EFL] Keep placeholder text visible until first input from user.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebKit EFLAssignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch
kenneth: review+
patch
gyuyoung.kim: review+
patch none

Kangil Han
Reported 2012-09-05 07:06:56 PDT
Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
Attachments
patch (1.32 KB, patch)
2012-09-05 07:08 PDT, Kangil Han 		kenneth: review+
DetailsFormatted DiffDiff
patch (1.33 KB, patch)
2012-09-05 07:51 PDT, Kangil Han 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
patch (1.47 KB, patch)
2012-09-05 19:40 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-09-05 07:08:08 PDT
Created attachment 162239 [details] patch
Kenneth Rohde Christiansen
Comment 2 2012-09-05 07:34:29 PDT
Comment on attachment 162239 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=162239&action=review > Source/WebCore/platform/efl/RenderThemeEfl.h:211 > + virtual bool shouldShowPlaceholderWhenFocused() const { return true; } no OVERRIDE?
Kangil Han
Comment 3 2012-09-05 07:51:10 PDT
Created attachment 162244 [details] patch Done!
Gyuyoung Kim
Comment 4 2012-09-05 08:15:49 PDT
Comment on attachment 162244 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=162244&action=review > Source/WebCore/platform/efl/RenderThemeEfl.h:211 > + virtual bool shouldShowPlaceholderWhenFocused() const OVERRIDE { return true; } I think it is better to move this virtual function to virtual function list side.
Gyuyoung Kim
Comment 5 2012-09-05 08:18:45 PDT
Comment on attachment 162244 [details] patch Oops, Kenneth r+ is removed. So, I set r+ again.
Kangil Han
Comment 6 2012-09-05 19:40:09 PDT
Created attachment 162397 [details] patch Done!
WebKit Review Bot
Comment 7 2012-09-06 03:47:21 PDT
Comment on attachment 162397 [details] patch Clearing flags on attachment: 162397 Committed r127723: <http://trac.webkit.org/changeset/127723>
WebKit Review Bot
Comment 8 2012-09-06 03:47:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.