Summary: | [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 61838 | ||||||
Attachments: |
|
Description
Chris Dumez
2012-09-05 05:23:20 PDT
Created attachment 162228 [details]
Patch
Comment on attachment 162228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162228&action=review > Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:62 > JSRetainPtr<JSStringRef> TestRunner::pathToLocalResource(JSStringRef url) > { > - return url; > + String requestedUrl(url->characters(), url->length()); Shouldn't you verify it is local? assert? > Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:66 > + if (requestedUrl.find("LayoutTests") != notFound) { Shouldn't it start with it? or is that not needed Comment on attachment 162228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162228&action=review >> Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:62 >> + String requestedUrl(url->characters(), url->length()); > > Shouldn't you verify it is local? assert? The function is called pathTo*Local*Resource() so I assumed it was not needed. FYI, I merely copied the implementation from DumpRenderTree. >> Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:66 >> + if (requestedUrl.find("LayoutTests") != notFound) { > > Shouldn't it start with it? or is that not needed Technically, it needs to start with file:///tmp/LayoutTests. This is a copy of the DRT implementation but I can improve it. Comment on attachment 162228 [details] Patch Clearing flags on attachment: 162228 Committed r127602: <http://trac.webkit.org/changeset/127602> All reviewed patches have been landed. Closing bug. |