| Summary: | [Qt] Automate the use of AllInOne files in the Qt build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||
| Component: | New Bugs | Assignee: | Simon Hausmann <hausmann> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abecsi, vestbo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Hausmann
2012-09-05 03:35:26 PDT
Created attachment 162207 [details]
Patch
With this feature enabled even on a Linux release build the size of the library shrinks by a whole megabyte. I'm wondering if we should enable this by default perhaps. Right now it is the default on Windows and Mac debug builds, but in theory there is a positive impact on release builds, too. Increased visibility to the compiler reduces the need for link time optimization support in the toolchain. FWIW the use of all-in-one files _is_ required for a debug build on Windows. Even with the current use of just SVGAllInOne.cpp we end up with a library that's too big for MSVC 2008 at least to handle. Adding for example AcessibilityAllinOne.cpp gets us juuust below the limit again, but I think we might as well take as much as we can get :) Comment on attachment 162207 [details]
Patch
nice!
Committed r127576: <http://trac.webkit.org/changeset/127576> |