[Tests] We should have mouse events test for multiple fields time input UI

• Component: Tools / Tests
• Status: RESOLVED FIXED

There are no test cases for mouse events on multiple fields time input UI.

Created attachment 162187 [details]
Patch 1

Comment on attachment 162187 [details]
Patch 1

Could you review this patch?
Thanks in advance.

[Kent Tamura]

Comment on attachment 162187 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=162187&action=review

> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html:54
> +mouseMoveTo(40, 15);

This is really font-dependent.
Please specify font-family:ahem; to avoid platform-dependency as possible.

Created attachment 162201 [details]
Patch 2

Comment on attachment 162201 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Set font-family of "time" input element to "ahem".

[Kent Tamura]

Comment on attachment 162201 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=162201&action=review

> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html:21
> +var input = document.getElementById("input");
> +input.setAttribute("style", "font-family:ahem");

Why don't you specify it in HTML?  <input id=input type=time style="font-family:ahem">

Also, you should specify font-size too because the default size is platform-dependent.

Created attachment 162204 [details]
Patch 3

Comment on attachment 162204 [details]
Patch 3

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Set font-family and font-size in HTML for input type "time"

[Kent Tamura]

Comment on attachment 162204 [details]
Patch 3

ok.
Please watch buildbot status carefully after landing this.

Comment on attachment 162204 [details]
Patch 3

Clearing flags on attachment: 162204

Committed r127668: <http://trac.webkit.org/changeset/127668>

All reviewed patches have been landed.  Closing bug.