Bug 95828

Summary: [EFL] Remove unnecessary logic in ewk_frame_source_get.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebKit EFLAssignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: g.czajkowski, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch none

Description Kangil Han 2012-09-05 01:10:46 PDT 
ewk_frame_source_get has unnecessary logic that has never been used in any case.
Comment 1 Kangil Han 2012-09-06 05:45:09 PDT 
Created attachment 162483 [details]
patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-09-06 06:13:18 PDT 
Comment on attachment 162483 [details]
patch

Could we have a test for this?
Comment 3 Kangil Han 2012-09-06 06:34:47 PDT 
(In reply to comment #2)
> (From update of attachment 162483 [details])
> Could we have a test for this?

This patch doesn't create a new API.
Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808.
:-)
Comment 4 Kenneth Rohde Christiansen 2012-09-06 06:36:50 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 162483 [details] [details])
> > Could we have a test for this?
> 
> This patch doesn't create a new API.
> Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808.
> :-)

Still this can be tested. Like add a test not adding <html> etc and show that it still works.
Comment 5 WebKit Review Bot 2012-09-06 07:38:07 PDT 
Comment on attachment 162483 [details]
patch

Clearing flags on attachment: 162483

Committed r127740: <http://trac.webkit.org/changeset/127740>
Comment 6 WebKit Review Bot 2012-09-06 07:38:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Ryuan Choi 2012-09-06 07:51:17 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 162483 [details] [details] [details])
> > > Could we have a test for this?
> > 
> > This patch doesn't create a new API.
> > Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808.
> > :-)
> 
> Still this can be tested. Like add a test not adding <html> etc and show that it still works.

I agree with you. we need to test this.

But I think that wk1 test framework should be improved.

I think that we can create new bug for it now and make test case after bug 94925 landed.