Bug 95820

Summary: [BlackBerry] Remove feature about:cache/disable and about:cache/enable
Product: WebKit Reporter: Jason Liu <jasonliuwebkit>
Component: WebKit BlackBerryAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch yong.li.webkit: review+

Jason Liu
Reported 2012-09-04 22:46:38 PDT
Remove this feature since we need to add a button in settings.
Attachments
Patch (1.85 KB, patch)
2012-09-04 22:50 PDT, Jason Liu 		no flags
DetailsFormatted DiffDiff
Patch (1.54 KB, patch)
2012-09-07 08:58 PDT, Rob Buis 		yong.li.webkit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jason Liu
Comment 1 2012-09-04 22:50:49 PDT
Created attachment 162162 [details] Patch
Rob Buis
Comment 2 2012-09-05 04:16:44 PDT
Comment on attachment 162162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162162&action=review Ok. > Source/WebKit/blackberry/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Any internal Pr or reviewer? If so state them here please.
Yong Li
Comment 3 2012-09-05 07:44:54 PDT
(In reply to comment #0) > Remove this feature since we need to add a button in settings. is the button ready yet?
Jason Liu
Comment 4 2012-09-05 18:53:57 PDT
(In reply to comment #3) > (In reply to comment #0) > > Remove this feature since we need to add a button in settings. > > is the button ready yet? Yes, it is ready.
WebKit Review Bot
Comment 5 2012-09-05 19:12:20 PDT
Comment on attachment 162162 [details] Patch Clearing flags on attachment: 162162 Committed r127680: <http://trac.webkit.org/changeset/127680>
WebKit Review Bot
Comment 6 2012-09-05 19:12:23 PDT
All reviewed patches have been landed. Closing bug.
Rob Buis
Comment 7 2012-09-07 08:58:09 PDT
Reopening to attach new patch.
Rob Buis
Comment 8 2012-09-07 08:58:11 PDT
Created attachment 162784 [details] Patch
Rob Buis
Comment 9 2012-09-07 10:09:27 PDT
Committed r127881: <http://trac.webkit.org/changeset/127881>
Note You need to log in before you can comment on or make changes to this bug.