Bug 95813

Summary:

Layout Test fast/innerHTML/innerHTML-iframe.html is failing

Product:

WebKit

Reporter:

Kenichi Ishibashi <bashi>

Component:

Tools / Tests

Assignee:

Hajime Morrita <morrita>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, haraken, morrita, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Kenichi Ishibashi

Reported 2012-09-04 18:47:50 PDT

The following layout test is failing fast/innerHTML/innerHTML-iframe.html See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=innerHTML-iframe.html Probable cause: http://trac.webkit.org/changeset/127534 Morrita, could you take a look?

Attachments
Patch (2.83 KB, patch) 2012-09-06 12:17 PDT, Sergey Glazunov	no flags	Details Formatted Diff Diff
Patch for landing (3.55 KB, patch) 2012-09-30 19:08 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kenichi Ishibashi

Comment 1 2012-09-04 20:33:45 PDT

Removed platform specific expectation. http://trac.webkit.org/changeset/127546

Kenichi Ishibashi

Comment 2 2012-09-05 18:01:14 PDT

Looks flaky. Updated expectation. http://trac.webkit.org/changeset/127667

Sergey Glazunov

Comment 3 2012-09-06 12:17:45 PDT

Created attachment 162553 [details] Patch It's my fault :(

Kentaro Hara

Comment 4 2012-09-06 15:54:42 PDT

Comment on attachment 162553 [details] Patch Looks OK.

Raphael Kubo da Costa (:rakuco)

Comment 5 2012-09-29 09:19:39 PDT

Hi, is there anything still blocking the change from being committed or can I cq+ it?

Hajime Morrita

Comment 6 2012-09-30 18:18:18 PDT

Comment on attachment 162553 [details] Patch I don't think so.

Hajime Morrita

Comment 7 2012-09-30 18:18:48 PDT

Comment on attachment 162553 [details] Patch Looks too old. I'll update and land this.

Hajime Morrita

Comment 8 2012-09-30 19:08:47 PDT

Created attachment 166399 [details] Patch for landing

WebKit Review Bot

Comment 9 2012-09-30 19:45:31 PDT

Comment on attachment 166399 [details] Patch for landing Clearing flags on attachment: 166399 Committed r130003: <http://trac.webkit.org/changeset/130003>

WebKit Review Bot

Comment 10 2012-09-30 19:45:35 PDT

All reviewed patches have been landed. Closing bug.

Raphael Kubo da Costa (:rakuco)

Comment 11 2012-10-01 01:26:32 PDT

Thanks a lot. For future reference, I have unskipped the test for the EFL port in <http://trac.webkit.org/changeset/130012>

Note You need to log in before you can comment on or make changes to this bug.