Summary: | REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rosyna <webkit-bugs> | ||||
Component: | Forms | Assignee: | Adele Peterson <adele> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | daniele.metilli, ian, jon | ||||
Priority: | P1 | Keywords: | Regression | ||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Rosyna
2006-06-25 13:33:23 PDT
This is a test. There should be no line breaks in this comment. This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment.This is a test. There should be no line breaks in this comment. Created attachment 9096 [details]
patch
Comment on attachment 9096 [details]
patch
clearing review flag. this isn't quite right.
That patch fixes some common cases of this problem, but RenderLayer::updateScrollInfoAfterLayout is still sometimes causing the layer to scroll back to the top. I'm not sure I understand this code.... we're calculating a new scroll position (line 1036): int newY = max(0, min(m_scrollY, scrollHeight() - m_object->clientHeight())); where m_scrollY is 26... which seems to be valid, but gets clobbered by this calculation. A more severe (and presumably related) problem with the scrolling of textareas is that touching the scrollbar instantly and reproducibly crashes the browser. Simon, please file a new bug about the crash, so we can fix that separately from this issue. Thanks! This is a regression from production Safari, so adding Regression keyword. Regressions are P1, and should have a Radar associated with them (adding NeedsRadar). Bug 9942 may be related to this bug since it exhibits similar behavior. *** Bug 10670 has been marked as a duplicate of this bug. *** Highlight scrolling is still crazy as of r16831. Major usability (i.e. testing) problem Comment on attachment 9096 [details]
patch
I actually do think this patch is right. The problem I was seeing before is caused by the flexbox double layout bugs. Now that we've moved textareas off of RenderFlexibleBox, this change should fully fix this scrolling problem.
Comment on attachment 9096 [details]
patch
oh, and of course, I'll update this patch so RenderTextField --> RenderTextControl
Comment on attachment 9096 [details]
patch
r=me
Committed revision 17560. |