Bug 95809

Summary: JSC: Allow the YarrJIT to use the assembler even when useJIT() is false
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix.
none
Removed unrelated file from patch.
ggaren: review+, buildbot: commit-queue-
svn up and retry. none

Description Mark Lam 2012-09-04 18:25:18 PDT 
Allow the YarrJIT to use the assembler even when useJIT() is false.  Introduce the useYarrJIT() option.

Without this, the YarrJIT was turned off for the llint C loop just because useJIT() is false.
Comment 1 Mark Lam 2012-09-04 18:27:28 PDT 
Created attachment 162145 [details]
Fix.
Comment 2 Mark Lam 2012-09-04 18:30:37 PDT 
Created attachment 162146 [details]
Removed unrelated file from patch.
Comment 3 Geoffrey Garen 2012-09-04 18:34:03 PDT 
Comment on attachment 162146 [details]
Removed unrelated file from patch.

r=me
Comment 4 Build Bot 2012-09-04 19:02:00 PDT 
Comment on attachment 162146 [details]
Removed unrelated file from patch.

Attachment 162146 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13740758
Comment 5 Mark Lam 2012-09-04 21:40:24 PDT 
Created attachment 162156 [details]
svn up and retry.
Comment 6 Mark Lam 2012-09-04 21:41:36 PDT 
The previous patch failed with the following message at the top:
Failed to run "['/home/buildbot/WebKit/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id..." exit_code: 2

Not sure why it should fail to patch / build on the win-ews.  It builds fine for me locally.  Retrying with the patch after an svn up.
Comment 7 Geoffrey Garen 2012-09-04 21:47:27 PDT 
Comment on attachment 162156 [details]
svn up and retry.

r=me
Comment 8 WebKit Review Bot 2012-09-04 22:12:03 PDT 
Comment on attachment 162156 [details]
svn up and retry.

Clearing flags on attachment: 162156

Committed r127554: <http://trac.webkit.org/changeset/127554>
Comment 9 WebKit Review Bot 2012-09-04 22:12:07 PDT 
All reviewed patches have been landed.  Closing bug.