Bug 95809

Summary: JSC: Allow the YarrJIT to use the assembler even when useJIT() is false
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix.
none
Removed unrelated file from patch.
ggaren: review+, buildbot: commit-queue-
svn up and retry. none

Mark Lam
Reported 2012-09-04 18:25:18 PDT
Allow the YarrJIT to use the assembler even when useJIT() is false. Introduce the useYarrJIT() option. Without this, the YarrJIT was turned off for the llint C loop just because useJIT() is false.
Attachments
Fix. (3.89 KB, patch)
2012-09-04 18:27 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Removed unrelated file from patch. (2.55 KB, patch)
2012-09-04 18:30 PDT, Mark Lam 		ggaren: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
svn up and retry. (2.58 KB, patch)
2012-09-04 21:40 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2012-09-04 18:27:28 PDT
Created attachment 162145 [details] Fix.
Mark Lam
Comment 2 2012-09-04 18:30:37 PDT
Created attachment 162146 [details] Removed unrelated file from patch.
Geoffrey Garen
Comment 3 2012-09-04 18:34:03 PDT
Comment on attachment 162146 [details] Removed unrelated file from patch. r=me
Build Bot
Comment 4 2012-09-04 19:02:00 PDT
Comment on attachment 162146 [details] Removed unrelated file from patch. Attachment 162146 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13740758
Mark Lam
Comment 5 2012-09-04 21:40:24 PDT
Created attachment 162156 [details] svn up and retry.
Mark Lam
Comment 6 2012-09-04 21:41:36 PDT
The previous patch failed with the following message at the top: Failed to run "['/home/buildbot/WebKit/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id..." exit_code: 2 Not sure why it should fail to patch / build on the win-ews. It builds fine for me locally. Retrying with the patch after an svn up.
Geoffrey Garen
Comment 7 2012-09-04 21:47:27 PDT
Comment on attachment 162156 [details] svn up and retry. r=me
WebKit Review Bot
Comment 8 2012-09-04 22:12:03 PDT
Comment on attachment 162156 [details] svn up and retry. Clearing flags on attachment: 162156 Committed r127554: <http://trac.webkit.org/changeset/127554>
WebKit Review Bot
Comment 9 2012-09-04 22:12:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.