Bug 95800

Summary:

Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, eric, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2012-09-04 17:28:20 PDT

Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp

Comment 1 Adam Barth 2012-09-04 17:29:15 PDT

Created attachment 162138 [details]
Patch

Comment 2 Benjamin Poulain 2012-09-04 18:17:14 PDT

Comment on attachment 162138 [details]
Patch

The patch looks good.

I remember we had issues before with StylePropertySet::getLayeredShorthandValue(). Would it be possible some code is actually expecting an empty value?

Comment 3 Adam Barth 2012-09-04 22:28:13 PDT

Comment on attachment 162138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162138&action=review

> Source/WebCore/css/StylePropertySet.cpp:428
> +    if (result.isEmpty())
> +        return String();

As far I as can tell, the problem was fixed by adding these two lines.

Comment 4 Benjamin Poulain 2012-09-04 22:30:04 PDT

I'll land manually if you don't mind, that will make my life easier on the Mac port.

Comment 5 Benjamin Poulain 2012-09-04 22:33:25 PDT

Comment on attachment 162138 [details]
Patch

Clearing flags on attachment: 162138

Committed r127555: <http://trac.webkit.org/changeset/127555>

Comment 6 Benjamin Poulain 2012-09-04 22:33:28 PDT

All reviewed patches have been landed.  Closing bug.