Bug 95787

Summary:

Add a const version of RenderBox::computeLogicalHeight

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, hyatt, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

94982

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Tony Chang 2012-09-04 15:18:18 PDT

Add a const version of RenderBox::computeLogicalHeight

Comment 1 Tony Chang 2012-09-04 15:25:42 PDT

Created attachment 162110 [details]
Patch

Comment 2 Tony Chang 2012-09-04 15:35:33 PDT

Comment on attachment 162110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162110&action=review

> Source/WebCore/rendering/RenderBox.cpp:1972
> +    computedValues.m_extent = logicalHeight();
> +    computedValues.m_position = logicalTop();

Maybe I should move these into the helper function?

> Source/WebCore/rendering/RenderBox.cpp:2139
> +        cb->addPercentHeightDescendant(const_cast<RenderBox*>(this));

This is gross, but we do the same thing in other places in the code.

Comment 3 Tony Chang 2012-09-04 16:33:46 PDT

Created attachment 162129 [details]
Patch for landing

Comment 4 WebKit Review Bot 2012-09-04 21:14:21 PDT

Comment on attachment 162129 [details]
Patch for landing

Clearing flags on attachment: 162129

Committed r127549: <http://trac.webkit.org/changeset/127549>

Comment 5 WebKit Review Bot 2012-09-04 21:14:24 PDT

All reviewed patches have been landed.  Closing bug.