Bug 95785

Summary: [chromium] Move static WebCompositor functions to WebCompositorSupport
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
add forward declaration of WebThread fishd: review+, fishd: commit-queue-

James Robinson
Reported 2012-09-04 14:48:25 PDT
[chromium] Move static WebCompositor functions to WebCompositorSupport
Attachments
Patch (2.86 KB, patch)
2012-09-04 14:49 PDT, James Robinson
no flags
add forward declaration of WebThread (3.05 KB, patch)
2012-09-04 15:23 PDT, James Robinson
fishd: review+
fishd: commit-queue-
James Robinson
Comment 1 2012-09-04 14:49:38 PDT
WebKit Review Bot
Comment 2 2012-09-04 14:51:11 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 3 2012-09-04 14:52:38 PDT
The staging on this is awkward, but the plan is to: 1.a) Land this new API 1.b) Land implementations on chromium side 2) Roll everybody forward enough to see these 3) Switch all Chromium callers over to the WebCompositorSupport versions 4) Roll everything forward to see that change 5) Switch all WebKit callers over to WebCompositorSupport versions, empty out WebCompositor interface. 1.a and 1.b can be done concurrently, I think everything has to happen roughly in serial.
James Robinson
Comment 4 2012-09-04 15:23:09 PDT
Created attachment 162109 [details] add forward declaration of WebThread
Darin Fisher (:fishd, Google)
Comment 5 2012-09-05 10:50:47 PDT
Comment on attachment 162109 [details] add forward declaration of WebThread View in context: https://bugs.webkit.org/attachment.cgi?id=162109&action=review > Source/Platform/chromium/public/WebCompositorSupport.h:62 > + virtual bool threadingEnabled() { return false; } nit: add a verb: "isThreadingEnabled" > Source/Platform/chromium/public/WebCompositorSupport.h:73 > + nit: extra new line
James Robinson
Comment 6 2012-09-05 18:16:18 PDT
Note You need to log in before you can comment on or make changes to this bug.