Bug 95773

Summary: [BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
Product: WebKit Reporter: Mike Fenton <mifenton>
Component: WebKit BlackBerryAssignee: Mike Fenton <mifenton>
Status: RESOLVED FIXED    
Severity: Normal CC: tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mike Fenton
Reported 2012-09-04 12:57:20 PDT
Even though PlatformKeyboardEvent::getCurrentModifierState is notImplemented, it should follow the other ports and initialize the values to false to ensure deterministic behaviour.
Attachments
Patch (2.34 KB, patch)
2012-09-04 12:59 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Fenton
Comment 1 2012-09-04 12:59:15 PDT
Created attachment 162085 [details] Patch
Rob Buis
Comment 2 2012-09-04 13:01:30 PDT
Comment on attachment 162085 [details] Patch Looks good.
WebKit Review Bot
Comment 3 2012-09-04 15:29:20 PDT
Comment on attachment 162085 [details] Patch Rejecting attachment 162085 [details] from commit-queue. New failing tests: http/tests/cache/subresource-expiration-1.html http/tests/cache/stopped-revalidation.html Full output: http://queues.webkit.org/results/13753553
WebKit Review Bot
Comment 4 2012-09-05 11:16:35 PDT
Comment on attachment 162085 [details] Patch Clearing flags on attachment: 162085 Committed r127613: <http://trac.webkit.org/changeset/127613>
WebKit Review Bot
Comment 5 2012-09-05 11:16:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.