Bug 95769

Summary:

[BlackBerry] Provide virtual dtor for DumpRenderTreeClient

Product:

WebKit

Reporter:

Rob Buis <rwlbuis>

Component:

WebKit BlackBerry

Assignee:

Rob Buis <rwlbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mifenton, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	yong.li.webkit: review+

Rob Buis

Reported 2012-09-04 12:13:46 PDT

We have virtual methods in DumpRenderTreeClient but no virtual dtor. This seems wrong since we delete a pointer to it in WebPage, so the subclass dtor in DumpRenderTree is not called.

Attachments
Patch (3.83 KB, patch) 2012-09-04 12:16 PDT, Rob Buis	yong.li.webkit: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2012-09-04 12:16:51 PDT

Created attachment 162077 [details] Patch

Rob Buis

Comment 2 2012-09-04 13:16:42 PDT

Committed r127486: <http://trac.webkit.org/changeset/127486>

Note You need to log in before you can comment on or make changes to this bug.