Bug 95755

Summary: ResourceErrorBase needs to identify timeouts
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: PlatformAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, aroben, ggaren, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 74802, 94796    
Attachments:
Description Flags
Adding isTimeout property. none

Description Dominik Röttsches (drott) 2012-09-04 09:45:12 PDT 
For bug 74802 I need to be able to distinguish resource errors which are caused by network timeouts. XHR uses a CachedResourceLoader, which in turn uses a SubResourceLoader. If a load failure occurs there, I'd like to set the status of the Cached resource to a new state TimedOut. I need to be able to identify timeouts in SubResourceLoader to be able to do that. That's why I'd like to introduce this distinction.
Comment 1 Dominik Röttsches (drott) 2012-09-04 11:00:20 PDT 
Created attachment 162061 [details]
Adding isTimeout property.
Comment 2 Dominik Röttsches (drott) 2012-09-04 11:39:11 PDT 
Thanks for the quick review, Alexey.
Comment 3 WebKit Review Bot 2012-09-04 13:29:46 PDT 
Comment on attachment 162061 [details]
Adding isTimeout property.

Clearing flags on attachment: 162061

Committed r127495: <http://trac.webkit.org/changeset/127495>
Comment 4 WebKit Review Bot 2012-09-04 13:29:51 PDT 
All reviewed patches have been landed.  Closing bug.