Bug 95744

Summary:

[chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium

Product:

WebKit

Reporter:

Koji Ishii <kojii>

Component:

Text

Assignee:

Peter Beverloo <peter>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gavinp, peter, scottmg

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Bug Depends on:

94822

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Description Koji Ishii 2012-09-04 06:47:54 PDT

From https://bugs.webkit.org/show_bug.cgi?id=94822#c9
> Hi, having OpenTypeVerticalData.cpp in both webcore_remaining and
> webcore_platform seems to break incremental linking on Windows
> Chromium. Is it possible to remove it from one of those libraries?

Comment 1 Koji Ishii 2012-09-04 06:50:25 PDT

There was a line for webcore_remaining
        ['OS=="win"', {
          'sources/': [
            ['include', '/opentype/'],
          ],
so, addition of 3 lines to WebCore.gyp in bug 94822 might be not necessary. Testing...

Comment 2 Koji Ishii 2012-09-04 08:19:21 PDT

hmm...I just followed the instructions at wiki to enable incremental linking without luck, so I can't verify the fix. I'm using msbuild with VS2010.

Scott, can you?

Comment 3 Koji Ishii 2012-09-04 08:25:46 PDT

Created attachment 162047 [details]
Patch

Comment 4 Scott Graham 2012-09-04 09:16:00 PDT

Yes, the removal of the three lines in WebCore.gyp makes the incremental build work again.

I'll test now that it doesn't break non-incremental.

Comment 5 Scott Graham 2012-09-04 09:35:28 PDT

Confirmed, this works in both styles of builds.

Comment 6 Peter Beverloo 2012-09-04 09:47:09 PDT

Created attachment 162056 [details]
Patch

Comment 7 Peter Beverloo 2012-09-04 09:50:23 PDT

Committed r127471: <http://trac.webkit.org/changeset/127471>

Comment 8 Peter Beverloo 2012-09-04 09:52:32 PDT

Comment on attachment 162056 [details]
Patch

Committed by request as a buildfix, verified by Scott. Koji also was the person who added these lines initially.