Summary: | [EFL] Fix build error in NetworkStateNotifierEfl.cpp | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, kangil.han, kenneth, lucas.de.marchi, ryuan.choi, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2012-09-04 03:14:09 PDT
Created attachment 161998 [details]
Patch
Attachment 161998 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The style error is expected. We have to code against style here to include headers in a specific order. Comment on attachment 161998 [details] Patch Clearing flags on attachment: 161998 Committed r127455: <http://trac.webkit.org/changeset/127455> All reviewed patches have been landed. Closing bug. |