Bug 95712

Summary: [CMAKE] Update cmakeconfig.h.cmake
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch
gyuyoung.kim: review+, gyuyoung.kim: commit-queue-
patch none

Jinwoo Song
Reported 2012-09-03 23:15:48 PDT
Update feature definitions which are missing compared to WebKitFeatures.cmake and sort the list by alphabet ordering.
Attachments
patch (3.77 KB, patch)
2012-09-03 23:19 PDT, Jinwoo Song 		gyuyoung.kim: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
patch (3.81 KB, patch)
2012-09-04 01:32 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2012-09-03 23:19:52 PDT
Created attachment 161969 [details] patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-09-04 00:12:36 PDT
Comment on attachment 161969 [details] patch Looks OK, thanks.
Gyuyoung Kim
Comment 3 2012-09-04 00:24:04 PDT
Comment on attachment 161969 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=161969&action=review > Source/cmakeconfig.h.cmake:85 > +#cmakedefine01 ENABLE_PLUGIN_PROXY_FOR_VIDEO Wrong alphabetical order.
Jinwoo Song
Comment 4 2012-09-04 01:32:52 PDT
Created attachment 161985 [details] patch
Jinwoo Song
Comment 5 2012-09-04 01:33:34 PDT
(In reply to comment #3) > (From update of attachment 161969 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161969&action=review > > > Source/cmakeconfig.h.cmake:85 > > +#cmakedefine01 ENABLE_PLUGIN_PROXY_FOR_VIDEO > > Wrong alphabetical order. Fixed. Thanks for checking my mistake!
WebKit Review Bot
Comment 6 2012-09-04 02:25:01 PDT
Comment on attachment 161985 [details] patch Clearing flags on attachment: 161985 Committed r127451: <http://trac.webkit.org/changeset/127451>
WebKit Review Bot
Comment 7 2012-09-04 02:25:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.