Bug 95712

Summary: [CMAKE] Update cmakeconfig.h.cmake
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch
gyuyoung.kim: review+, gyuyoung.kim: commit-queue-
patch none

Description Jinwoo Song 2012-09-03 23:15:48 PDT
Update feature definitions which are missing compared to WebKitFeatures.cmake
and sort the list by alphabet ordering.
Comment 1 Jinwoo Song 2012-09-03 23:19:52 PDT
Created attachment 161969 [details]
patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-09-04 00:12:36 PDT
Comment on attachment 161969 [details]
patch

Looks OK, thanks.
Comment 3 Gyuyoung Kim 2012-09-04 00:24:04 PDT
Comment on attachment 161969 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161969&action=review

> Source/cmakeconfig.h.cmake:85
> +#cmakedefine01 ENABLE_PLUGIN_PROXY_FOR_VIDEO

Wrong alphabetical order.
Comment 4 Jinwoo Song 2012-09-04 01:32:52 PDT
Created attachment 161985 [details]
patch
Comment 5 Jinwoo Song 2012-09-04 01:33:34 PDT
(In reply to comment #3)
> (From update of attachment 161969 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161969&action=review
> 
> > Source/cmakeconfig.h.cmake:85
> > +#cmakedefine01 ENABLE_PLUGIN_PROXY_FOR_VIDEO
> 
> Wrong alphabetical order.

Fixed. Thanks for checking my mistake!
Comment 6 WebKit Review Bot 2012-09-04 02:25:01 PDT
Comment on attachment 161985 [details]
patch

Clearing flags on attachment: 161985

Committed r127451: <http://trac.webkit.org/changeset/127451>
Comment 7 WebKit Review Bot 2012-09-04 02:25:04 PDT
All reviewed patches have been landed.  Closing bug.