Bug 95707

Summary:

Add partial load tests for PNG images

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

Tools / Tests

Assignee:

noel gordon <noel.gordon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

78239

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Add mac results	none
Patch for landing	none
Patch for landing (honest)	none
Patch	none

noel gordon

Reported 2012-09-03 21:36:30 PDT

Per https://bugs.webkit.org/show_bug.cgi?id=78239#c20, add a partial load test(s) for PNG images.

Attachments
Patch (588.52 KB, patch) 2012-09-05 01:35 PDT, noel gordon	no flags	Details Formatted Diff Diff
Add mac results (316.62 KB, patch) 2012-09-06 00:46 PDT, noel gordon	no flags	Details Formatted Diff Diff
Patch for landing (317.00 KB, patch) 2012-09-06 21:51 PDT, noel gordon	no flags	Details Formatted Diff Diff
Patch for landing (honest) (317.04 KB, patch) 2012-09-06 23:44 PDT, noel gordon	no flags	Details Formatted Diff Diff
Patch (317.08 KB, patch) 2012-09-18 19:46 PDT, noel gordon	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

noel gordon

Comment 1 2012-09-05 01:35:54 PDT

Created attachment 162185 [details] Patch

noel gordon

Comment 2 2012-09-06 00:46:59 PDT

Created attachment 162439 [details] Add mac results

noel gordon

Comment 3 2012-09-06 21:39:36 PDT

Noticed a difference for partial loaded png images with no alpha on the mac port. The image tag background is black in that case, it should be blue. Filed bug 96064 about that.

noel gordon

Comment 4 2012-09-06 21:51:22 PDT

Created attachment 162668 [details] Patch for landing

noel gordon

Comment 5 2012-09-06 23:44:27 PDT

Created attachment 162684 [details] Patch for landing (honest)

noel gordon

Comment 6 2012-09-17 21:35:12 PDT

Review please?

Adam Barth

Comment 7 2012-09-18 12:56:35 PDT

Comment on attachment 162684 [details] Patch for landing (honest) View in context: https://bugs.webkit.org/attachment.cgi?id=162684&action=review > LayoutTests/http/tests/images/png-partial-load.html:4 > + testRunner.dumpAsText(pixelTest = true); You can remove the "pixelTest" variable here. It doesn't seem to be used anywhere. > LayoutTests/http/tests/images/png-partial-load.html:20 > + if (window.testRunner) testRunner.notifyDone(); two lines pls

noel gordon

Comment 8 2012-09-18 19:45:05 PDT

(In reply to comment #7) Done & done.

noel gordon

Comment 9 2012-09-18 19:46:48 PDT

Created attachment 164647 [details] Patch

WebKit Review Bot

Comment 10 2012-09-18 20:08:17 PDT

Comment on attachment 164647 [details] Patch Clearing flags on attachment: 164647 Committed r128961: <http://trac.webkit.org/changeset/128961>

WebKit Review Bot

Comment 11 2012-09-18 20:08:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.