Bug 95707

Summary:

Add partial load tests for PNG images

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

Tools / Tests

Assignee:

noel gordon <noel.gordon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

78239

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Add mac results	none
Patch for landing	none
Patch for landing (honest)	none
Patch	none

Description noel gordon 2012-09-03 21:36:30 PDT

Per https://bugs.webkit.org/show_bug.cgi?id=78239#c20, add a partial load test(s) for PNG images.

Comment 1 noel gordon 2012-09-05 01:35:54 PDT

Created attachment 162185 [details]
Patch

Comment 2 noel gordon 2012-09-06 00:46:59 PDT

Created attachment 162439 [details]
Add mac results

Comment 3 noel gordon 2012-09-06 21:39:36 PDT

Noticed a difference for partial loaded png images with no alpha on the mac port.  The image tag background is black in that case, it should be blue.  Filed bug 96064 about that.

Comment 4 noel gordon 2012-09-06 21:51:22 PDT

Created attachment 162668 [details]
Patch for landing

Comment 5 noel gordon 2012-09-06 23:44:27 PDT

Created attachment 162684 [details]
Patch for landing (honest)

Comment 6 noel gordon 2012-09-17 21:35:12 PDT

Review please?

Comment 7 Adam Barth 2012-09-18 12:56:35 PDT

Comment on attachment 162684 [details]
Patch for landing (honest)

View in context: https://bugs.webkit.org/attachment.cgi?id=162684&action=review

> LayoutTests/http/tests/images/png-partial-load.html:4
> +    testRunner.dumpAsText(pixelTest = true);

You can remove the "pixelTest" variable here.  It doesn't seem to be used anywhere.

> LayoutTests/http/tests/images/png-partial-load.html:20
> +    if (window.testRunner) testRunner.notifyDone();

two lines pls

Comment 8 noel gordon 2012-09-18 19:45:05 PDT

(In reply to comment #7)
Done & done.

Comment 9 noel gordon 2012-09-18 19:46:48 PDT

Created attachment 164647 [details]
Patch

Comment 10 WebKit Review Bot 2012-09-18 20:08:17 PDT

Comment on attachment 164647 [details]
Patch

Clearing flags on attachment: 164647

Committed r128961: <http://trac.webkit.org/changeset/128961>

Comment 11 WebKit Review Bot 2012-09-18 20:08:20 PDT

All reviewed patches have been landed.  Closing bug.