Bug 95689

Summary: [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Ryuan Choi 2012-09-03 07:33:54 PDT 
In Minibrowser & EWebLauncher, webview lost focus when url bar is clicked.
So, key events are always generated in url bar although user clicked webview.

Below is simple step to reproduce this bug.
1. load google.com
2. click url bar
3. click search field in webview.
4. try to write something.
Comment 1 Ryuan Choi 2012-09-03 07:49:41 PDT 
Created attachment 161928 [details]
Patch
Comment 2 Chris Dumez 2012-09-03 07:57:51 PDT 
Comment on attachment 161928 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161928&action=review

LGTM but small nits:

> Tools/MiniBrowser/efl/main.c:136
> +on_mouse_down(void* data, Evas* e, Evas_Object* webview, void* event_info)

Stars on wrong side.

> Tools/MiniBrowser/efl/main.c:138
> +    Evas_Event_Mouse_Down *ev = (Evas_Event_Mouse_Down*) event_info;

Shouldn't there be a space before the star?
Comment 3 Ryuan Choi 2012-09-03 08:26:46 PDT 
Created attachment 161934 [details]
Patch
Comment 4 Ryuan Choi 2012-09-03 08:27:56 PDT 
Created attachment 161935 [details]
Patch
Comment 5 Ryuan Choi 2012-09-03 08:30:44 PDT 
(In reply to comment #2)
> (From update of attachment 161928 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161928&action=review
> 
> LGTM but small nits:
> 
> > Tools/MiniBrowser/efl/main.c:136
> > +on_mouse_down(void* data, Evas* e, Evas_Object* webview, void* event_info)
> 
> Stars on wrong side.
> 
> > Tools/MiniBrowser/efl/main.c:138
> > +    Evas_Event_Mouse_Down *ev = (Evas_Event_Mouse_Down*) event_info;
> 
> Shouldn't there be a space before the star?

Right, Fixed style issues in the codes which I change.
Comment 6 Chris Dumez 2012-09-03 08:42:00 PDT 
Comment on attachment 161935 [details]
Patch

LGTM. Thanks.
Comment 7 Kenneth Rohde Christiansen 2012-09-03 08:51:06 PDT 
Comment on attachment 161935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161935&action=review

> Tools/ChangeLog:10
> +        So, there are bug that key events are always generated in url bar although
> +        user clicked webview.

Could use a bit more 'the's. although the user clicked on the web view
Comment 8 Ryuan Choi 2012-09-03 09:01:42 PDT 
Created attachment 161936 [details]
Patch
Comment 9 Ryuan Choi 2012-09-03 09:04:50 PDT 
Comment on attachment 161936 [details]
Patch

I updated comments.
s/webview/the web view/
s/focus/the focus/
s/user/the user/
Comment 10 WebKit Review Bot 2012-09-03 11:38:32 PDT 
Comment on attachment 161936 [details]
Patch

Clearing flags on attachment: 161936

Committed r127431: <http://trac.webkit.org/changeset/127431>
Comment 11 WebKit Review Bot 2012-09-03 11:38:36 PDT 
All reviewed patches have been landed.  Closing bug.