Bug 95689

Summary: [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Ryuan Choi
Reported 2012-09-03 07:33:54 PDT
In Minibrowser & EWebLauncher, webview lost focus when url bar is clicked. So, key events are always generated in url bar although user clicked webview. Below is simple step to reproduce this bug. 1. load google.com 2. click url bar 3. click search field in webview. 4. try to write something.
Attachments
Patch (3.02 KB, patch)
2012-09-03 07:49 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (3.16 KB, patch)
2012-09-03 08:26 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (3.16 KB, patch)
2012-09-03 08:27 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (3.20 KB, patch)
2012-09-03 09:01 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-09-03 07:49:41 PDT
Created attachment 161928 [details] Patch
Chris Dumez
Comment 2 2012-09-03 07:57:51 PDT
Comment on attachment 161928 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161928&action=review LGTM but small nits: > Tools/MiniBrowser/efl/main.c:136 > +on_mouse_down(void* data, Evas* e, Evas_Object* webview, void* event_info) Stars on wrong side. > Tools/MiniBrowser/efl/main.c:138 > + Evas_Event_Mouse_Down *ev = (Evas_Event_Mouse_Down*) event_info; Shouldn't there be a space before the star?
Ryuan Choi
Comment 3 2012-09-03 08:26:46 PDT
Created attachment 161934 [details] Patch
Ryuan Choi
Comment 4 2012-09-03 08:27:56 PDT
Created attachment 161935 [details] Patch
Ryuan Choi
Comment 5 2012-09-03 08:30:44 PDT
(In reply to comment #2) > (From update of attachment 161928 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161928&action=review > > LGTM but small nits: > > > Tools/MiniBrowser/efl/main.c:136 > > +on_mouse_down(void* data, Evas* e, Evas_Object* webview, void* event_info) > > Stars on wrong side. > > > Tools/MiniBrowser/efl/main.c:138 > > + Evas_Event_Mouse_Down *ev = (Evas_Event_Mouse_Down*) event_info; > > Shouldn't there be a space before the star? Right, Fixed style issues in the codes which I change.
Chris Dumez
Comment 6 2012-09-03 08:42:00 PDT
Comment on attachment 161935 [details] Patch LGTM. Thanks.
Kenneth Rohde Christiansen
Comment 7 2012-09-03 08:51:06 PDT
Comment on attachment 161935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161935&action=review > Tools/ChangeLog:10 > + So, there are bug that key events are always generated in url bar although > + user clicked webview. Could use a bit more 'the's. although the user clicked on the web view
Ryuan Choi
Comment 8 2012-09-03 09:01:42 PDT
Created attachment 161936 [details] Patch
Ryuan Choi
Comment 9 2012-09-03 09:04:50 PDT
Comment on attachment 161936 [details] Patch I updated comments. s/webview/the web view/ s/focus/the focus/ s/user/the user/
WebKit Review Bot
Comment 10 2012-09-03 11:38:32 PDT
Comment on attachment 161936 [details] Patch Clearing flags on attachment: 161936 Committed r127431: <http://trac.webkit.org/changeset/127431>
WebKit Review Bot
Comment 11 2012-09-03 11:38:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.