Bug 95652

Summary: Don't create access error strings if there is no access error
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebCore JavaScriptAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, barraclough, eric, ggaren, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 93407    
Bug Blocks:    
Attachments:
Description Flags
the patch abarth: review+, abarth: commit-queue-

Description Filip Pizlo 2012-09-02 00:50:50 PDT 
Patch forthcoming.

I'm just trying to undo our 50% regression in pdfjs caused by http://trac.webkit.org/changeset/126165.
Comment 1 Filip Pizlo 2012-09-02 00:54:48 PDT 
Created attachment 161839 [details]
the patch
Comment 2 Adam Barth 2012-09-02 01:02:24 PDT 
Comment on attachment 161839 [details]
the patch

I would just remove the |result| temporary and just early return if shouldAllowAccessToFoo returns true.  Thanks for fixing my regression.
Comment 3 Filip Pizlo 2012-09-02 01:03:11 PDT 
(In reply to comment #2)
> (From update of attachment 161839 [details])
> I would just remove the |result| temporary and just early return if shouldAllowAccessToFoo returns true.  Thanks for fixing my regression.

Good point!  I will do that instead.

Thanks for the quick review!
Comment 4 Filip Pizlo 2012-09-02 01:34:03 PDT 
Landed in http://trac.webkit.org/changeset/127387