| Summary: | [Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 161825 [details]
Patch
Created attachment 161829 [details]
Patch
Comment on attachment 161829 [details] Patch Clearing flags on attachment: 161829 Committed r127377: <http://trac.webkit.org/changeset/127377> All reviewed patches have been landed. Closing bug. |
As part of the fix for 72811, a test which needed to be updated was updated by Zan. (Thanks!) One more tweak needs to be made. Now that my build has finished, I am seeing: --- /home/jd/checkout/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt +++ /home/jd/checkout/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-actual.txt @@ -19,7 +19,8 @@ AXRole: document frame AXRole: panel AXValue: <obj>text area<\n> AXRole: entry AXValue: text area - AXRole: push button + AXRole: section AXValue: Div<\n><obj>button + AXRole: push button AXRole: heading AXValue: Heading<\n><obj>button<\n><obj> The push button is inside a div and the div has additional content, so one would expect the div to be in the accessible hierarchy. And in gtk a11y, div == section. Thus the above seems correct. The question is, why didn't the bot where the test originally failed see that? I'll attach a patch and leave it to the gardeners to sort out the bots. :)