Bug 95640

Summary:

[EFL] Add missing semicolon at the end of some lines.

Product:

WebKit

Reporter:

Byungwoo Lee <bw80.lee>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Byungwoo Lee

Reported 2012-09-01 02:00:12 PDT

In the ewk_view.cpp, there are some lines that doesn't have semicolon, but there was no build error about this. This is caused by some macro definition in the file.

Attachments
Patch (13.92 KB, patch) 2012-09-01 08:25 PDT, Byungwoo Lee	no flags	Details Formatted Diff Diff
Patch (13.92 KB, patch) 2012-09-01 08:29 PDT, Byungwoo Lee	no flags	Details Formatted Diff Diff
Patch (8.27 KB, patch) 2012-09-01 17:59 PDT, Byungwoo Lee	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Byungwoo Lee

Comment 1 2012-09-01 08:25:36 PDT

Created attachment 161827 [details] Patch

Byungwoo Lee

Comment 2 2012-09-01 08:29:18 PDT

Created attachment 161828 [details] Patch

Byungwoo Lee

Comment 3 2012-09-01 08:29:42 PDT

Fixed typo in Changelog.

Chris Dumez

Comment 4 2012-09-01 09:18:21 PDT

Comment on attachment 161828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161828&action=review On principal, I like the idea. > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:168 > + } while (0) We don't technically need to do { } while(0) here. Why not simply get rid of the semicolon at the end of evas_object_smart_data_get(ewkView)?

Raphael Kubo da Costa (:rakuco)

Comment 5 2012-09-01 10:52:01 PDT

Comment on attachment 161828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161828&action=review EWK_VIEW_TYPE_CHECK does not seem to have had any meaningful change, I don't understand the reason for the additional spaces at the end of the lines. >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:168 >> + } while (0) > > We don't technically need to do { } while(0) here. Why not simply get rid of the semicolon at the end of evas_object_smart_data_get(ewkView)? The best reason I can think of is convention.

Byungwoo Lee

Comment 6 2012-09-01 17:44:35 PDT

(In reply to comment #5) > EWK_VIEW_TYPE_CHECK does not seem to have had any meaningful change, I don't understand the reason for the additional spaces at the end of the lines. It was because that all the position of the '\' were fitted in the previous code. > > >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:168 > >> + } while (0) > > > > We don't technically need to do { } while(0) here. Why not simply get rid of the semicolon at the end of evas_object_smart_data_get(ewkView)? > > The best reason I can think of is convention. Yes, I just add the while (0), but I think removing semicolon will be easier for the line. And with this additional fitting for '\' also not required. I'll change those. Thanks :)

Byungwoo Lee

Comment 7 2012-09-01 17:59:18 PDT

Created attachment 161835 [details] Patch

Chris Dumez

Comment 8 2012-09-01 23:29:40 PDT

Comment on attachment 161835 [details] Patch LGTM.

Raphael Kubo da Costa (:rakuco)

Comment 9 2012-09-02 03:30:17 PDT

Comment on attachment 161835 [details] Patch Looks good, thank you.

WebKit Review Bot

Comment 10 2012-09-02 10:43:28 PDT

Comment on attachment 161835 [details] Patch Clearing flags on attachment: 161835 Committed r127390: <http://trac.webkit.org/changeset/127390>

WebKit Review Bot

Comment 11 2012-09-02 10:43:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.