| Summary: | Elide test names when running new-run-webkit-tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, ojan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tony Chang
2012-08-31 17:01:41 PDT
Created attachment 161793 [details]
Patch
You can see the jankiness if you run layout tests with an 80 col wide terminal. BTW, I intentionally didn't implement on Windows python, but it looks like it should be possible: http://code.google.com/p/python-progressbar/issues/detail?id=12 Comment on attachment 161793 [details]
Patch
looks reasonable, the previous output works fine on at least some platforms, I think (or at least it used to). What platforms / TERM settings are you seeing issues on?
On Linux, if the test is longer than the line, it leaves the text and scrolls by. (In reply to comment #5) > On Linux, if the test is longer than the line, it leaves the text and scrolls by. Hm. ssh'ed in from my mac (Terminal running ssh, TERM=xterm256color), it mostly works (although I have seen it get out of sync in some cases; that's probably a separate bug). Perhaps it's your terminal emulator that has a problem? That said, I think the change is good, don't get me wrong ... Comment on attachment 161793 [details]
Patch
You probably need to run it from a Linux terminal to see the problem.
Comment on attachment 161793 [details] Patch Clearing flags on attachment: 161793 Committed r127478: <http://trac.webkit.org/changeset/127478> All reviewed patches have been landed. Closing bug. Committed r127482: <http://trac.webkit.org/changeset/127482> |