Bug 95622
Summary: | css3/filters/composited-during-animation-layertree.html sometimes produces empty results | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> |
Component: | CSS | Assignee: | Cameron McCormack (:heycam) <heycam> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | dpino, krit, simon.fraser, thorton, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=171600 | ||
Bug Depends on: | |||
Bug Blocks: | 68469 |
Jessie Berlin
This is apparently expected behavior (since empty results were checked in for mac when the test was originally added in http://trac.webkit.org/changeset/109953), but I don't understand why. On Mountain Lion, there is actually a layer tree printed:
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r127318%20(503)/css3/filters/composited-during-animation-layertree-pretty-diff.html
--- /Volumes/Data/slave/mountainlion-debug-tests-wk2/build/layout-test-results/css3/filters/composited-during-animation-layertree-expected.txt
+++ /Volumes/Data/slave/mountainlion-debug-tests-wk2/build/layout-test-results/css3/filters/composited-during-animation-layertree-actual.txt
@@ -2,4 +2,34 @@
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 800.00 600.00)
+ (children 4
+ (GraphicsLayer
+ (position 18.00 18.00)
+ (bounds 160.00 90.00)
+ (drawsContent 1)
+ )
+ (GraphicsLayer
+ (position 18.00 132.00)
+ (bounds 160.00 90.00)
+ (drawsContent 1)
+ )
+ (GraphicsLayer
+ (position 18.00 246.00)
+ (bounds 160.00 90.00)
+ (drawsContent 1)
+ )
+ (GraphicsLayer
+ (position 18.00 360.00)
+ (bounds 160.00 90.00)
+ (drawsContent 1)
+ )
+ )
+ )
+ )
+)
Why are we expecting empty results on Lion? Is some feature not on in Lion?
I am going to add the expected results for ML and move the empty results to mac-lion to get the bots greener.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/12229951>
Alexey Proskuryakov
This test sometimes (rarely) produces empty results on all Mountain Lion bots (WK1 and WK2).
Also, I can reproduce getting empty results every time when it's run repeatedly:
$ run-webkit-tests css3/filters/composited-during-animation-layertree.html --repeat-each 100
…
[2/100] css3/filters/composited-during-animation-layertree.html failed unexpectedly (text diff)
[3/100] css3/filters/composited-during-animation-layertree.html failed unexpectedly (text diff)
[4/100] css3/filters/composited-during-animation-layertree.html failed unexpectedly (text diff)
[5/100] css3/filters/composited-during-animation-layertree.html failed unexpectedly (text diff)
[6/100] css3/filters/composited-during-animation-layertree.html failed unexpectedly (text diff)
…
Marked as flaky in <http://trac.webkit.org/r157625>.
Diego Pino
GLIB ports (WebKitGTK and WPE) produce similar results (https://bugs.webkit.org/show_bug.cgi?id=171600).
The general baseline is empty. Isn't that a mistake?
https://github.com/WebKit/WebKit/blob/main/LayoutTests/css3/filters/composited-during-animation-layertree-expected.txt
Cameron McCormack (:heycam)
Pull request: https://github.com/WebKit/WebKit/pull/37208
EWS
Committed 287140@main (2020ece42d14): <https://commits.webkit.org/287140@main>
Reviewed commits have been landed. Closing PR #37208 and removing active labels.
EWS
Test gardening commit 287955@main (5e594e06978b): <https://commits.webkit.org/287955@main>
Reviewed commits have been landed. Closing PR #38084 and removing active labels.