Bug 95595

Summary: Make computeBlockDirectionMargins const
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyatt, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94982    
Attachments:
Description Flags
Patch
none
Patch for landing none

Tony Chang
Reported 2012-08-31 11:26:06 PDT
Make computeBlockDirectionMargins const
Attachments
Patch (9.84 KB, patch)
2012-08-31 11:31 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.80 KB, patch)
2012-08-31 14:41 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-08-31 11:31:16 PDT
Created attachment 161742 [details] Patch
Ojan Vafai
Comment 2 2012-08-31 12:28:05 PDT
Comment on attachment 161742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161742&action=review > Source/WebCore/rendering/RenderBox.cpp:2415 > + computeBlockDirectionMargins(containingBlock, > + marginBefore, marginAfter); Meh to wrapping this.
Tony Chang
Comment 3 2012-08-31 14:41:20 PDT
Created attachment 161778 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-08-31 17:59:46 PDT
Comment on attachment 161778 [details] Patch for landing Clearing flags on attachment: 161778 Committed r127346: <http://trac.webkit.org/changeset/127346>
WebKit Review Bot
Comment 5 2012-08-31 17:59:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.