Bug 95585

Summary: Web Inspector: Implement SCSS source highlighter
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Rebased patch
none
Patch vsevik: review+

Alexander Pavlov (apavlov)
Reported 2012-08-31 09:31:58 PDT
Patch to follow.
Attachments
Patch (106.60 KB, patch)
2012-09-03 07:13 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (131.07 KB, patch)
2012-09-03 08:18 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Rebased patch (130.94 KB, patch)
2012-09-05 01:59 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (129.74 KB, patch)
2012-09-06 01:35 PDT, Alexander Pavlov (apavlov) 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2012-09-03 07:13:40 PDT
Created attachment 161922 [details] Patch
Pavel Feldman
Comment 2 2012-09-03 07:45:48 PDT
Comment on attachment 161922 [details] Patch Could you reuse the CSS and join them?
Alexander Pavlov (apavlov)
Comment 3 2012-09-03 08:18:16 PDT
Created attachment 161933 [details] Patch
Alexander Pavlov (apavlov)
Comment 4 2012-09-05 01:59:25 PDT
Created attachment 162191 [details] Rebased patch
Alexander Pavlov (apavlov)
Comment 5 2012-09-06 01:35:48 PDT
Created attachment 162449 [details] Patch
Vsevolod Vlasov
Comment 6 2012-09-07 01:52:28 PDT
Comment on attachment 162449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162449&action=review > Source/WebCore/inspector/front-end/ContentProviders.js:274 > + mimeType: function() This one is redundant, please remove.
Vsevolod Vlasov
Comment 7 2012-09-07 06:09:00 PDT
Comment on attachment 162449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162449&action=review This makes me sick. lgtm. > Source/WebCore/inspector/front-end/SourceCSSTokenizer.re2js:80 > +WebInspector.SourceCSSTokenizer.AtRelatedKeywords = [ SCSSAt..
Alexander Pavlov (apavlov)
Comment 8 2012-09-07 06:24:24 PDT
Committed r127864: <http://trac.webkit.org/changeset/127864>
Note You need to log in before you can comment on or make changes to this bug.