Bug 95567

Summary: Web Inspector: get rid of context execution id fallback.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Description Pavel Feldman 2012-08-31 07:01:44 PDT 
We now assign execution id upon UI population.
Comment 1 Pavel Feldman 2012-08-31 08:52:33 PDT 
Created attachment 161709 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-03 01:28:11 PDT 
Comment on attachment 161709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161709&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:47
> +    this._contextSelector = new WebInspector.StatusBarComboBox(this._updateExecutionContextSelector.bind(this), "console-context");

Let's rename _contextSelector to _frameSelector or _contextListSelector.

> Source/WebCore/inspector/front-end/JavaScriptContextManager.js:103
> +        var cpmtextList = this._frameIdToContextList[context.frameId];

cpmtextList ?
Comment 3 Pavel Feldman 2012-09-03 01:40:25 PDT 
Created attachment 161879 [details]
Patch
Comment 4 Pavel Feldman 2012-09-03 01:54:27 PDT 
Committed r127412: <http://trac.webkit.org/changeset/127412>