Bug 95563

Summary:

[JSC] Clear exceptions thrown in Dictionary

Product:

WebKit

Reporter:

Michael Pruett <michael>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

dglazkov, ggaren, haraken, jsbell, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-
Patch	none
Patch	none
Patch	haraken: review-

Michael Pruett

Reported 2012-08-31 05:41:36 PDT

Exceptions thrown in JSDictionary::get() are not cleared, causing subsequent calls to JSDictionary::get() to fail spuriously.

Attachments
Patch (2.30 KB, patch) 2012-08-31 07:13 PDT, Michael Pruett	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (2.50 KB, patch) 2012-12-03 11:33 PST, Michael Pruett	no flags	Details Formatted Diff Diff
Patch (2.48 KB, patch) 2012-12-03 12:16 PST, Michael Pruett	no flags	Details Formatted Diff Diff
Patch (2.54 KB, patch) 2012-12-03 13:43 PST, Michael Pruett	haraken: review-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Michael Pruett

Comment 1 2012-08-31 07:13:49 PDT

Created attachment 161692 [details] Patch

WebKit Review Bot

Comment 2 2012-08-31 07:54:15 PDT

Comment on attachment 161692 [details] Patch Attachment 161692 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13720198 New failing tests: animations/suspend-resume-animation-events.html

Michael Pruett

Comment 3 2012-12-03 11:33:48 PST

Created attachment 177295 [details] Patch

Michael Pruett

Comment 4 2012-12-03 12:16:22 PST

Created attachment 177306 [details] Patch

Michael Pruett

Comment 5 2012-12-03 13:43:20 PST

Created attachment 177318 [details] Patch

Michael Pruett

Comment 6 2012-12-03 14:52:56 PST

This change is necessary to implement IndexedDB for JSC. Without this change, numerous calls to Dictionary::get() and Dictionary::getWithUndefinedOrNullCheck() fail in IDBDatabase::createObjectStore() and IDBObjectStore::createIndex() because earlier accesses to the options dictionary generated exceptions. With this proposed patch and that in bug 103484, IndexedDB for JSC passes 143 out of 196 layout tests in storage/indexeddb.

Kentaro Hara

Comment 7 2012-12-03 15:54:05 PST

Comment on attachment 177318 [details] Patch I think this problem should be fixed in the IndexedDB layer not in the Dictionary layer. Please see discussion in bug 96614.

Kentaro Hara

Comment 8 2012-12-03 15:54:21 PST

*** This bug has been marked as a duplicate of bug 96614 ***

Note You need to log in before you can comment on or make changes to this bug.