Bug 95545

Summary: [Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.html should dump text instead of render tree
Product: WebKit Reporter: yosin
Component: Tools / TestsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95542    
Attachments:
Description Flags
Patch 1
none
Patch 2 none

Description yosin 2012-08-31 02:53:46 PDT
For appearance tests, structure of render tree isn't important for testing.
Comment 1 yosin 2012-08-31 03:12:05 PDT
Created attachment 161648 [details]
Patch 1
Comment 2 yosin 2012-08-31 03:12:53 PDT
Comment on attachment 161648 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-08-31 03:23:27 PDT
Comment on attachment 161648 [details]
Patch 1

dumpAsText(true) is needed.
text expectation should be updated.
Comment 4 yosin 2012-08-31 03:30:27 PDT
Created attachment 161652 [details]
Patch 2
Comment 5 yosin 2012-08-31 03:31:40 PDT
Comment on attachment 161652 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Added fast/forms/time-multiple-fields/*-expected.txt
* Changed to dumpAsText(true) in HTML fiels
* Update ChangeLog
Comment 6 Kent Tamura 2012-09-02 17:59:59 PDT
Comment on attachment 161652 [details]
Patch 2

ok
Comment 7 yosin 2012-09-02 18:04:38 PDT
Comment on attachment 161652 [details]
Patch 2

Clearing flags on attachment: 161652

Committed r127396: <http://trac.webkit.org/changeset/127396>
Comment 8 yosin 2012-09-02 18:04:42 PDT
All reviewed patches have been landed.  Closing bug.