Bug 95542

Summary: [Forms] AM/PM field of multiple fields time input UI should be fixed width
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, macpherson, menard, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 95545    
Bug Blocks: 95660    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3 none

Description yosin 2012-08-31 02:42:06 PDT 
For Japanese, AM/PM symbols are in Kanji, these texts are longer than "--".
For Arabic, AM/PM symbols are one character, these characters are shorter than "--".
Comment 1 yosin 2012-08-31 03:57:02 PDT 
Created attachment 161656 [details]
Patch 1
Comment 2 yosin 2012-09-02 18:34:58 PDT 
Created attachment 161852 [details]
Patch 2
Comment 3 yosin 2012-09-02 18:35:40 PDT 
Comment on attachment 161852 [details]
Patch 2

Could you review this patch?
Thanks in advance.
Comment 4 Kent Tamura 2012-09-02 18:47:57 PDT 
Comment on attachment 161852 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=161852&action=review

> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:35
> +#include "TextRun.h"
> +#include <wtf/text/StringBuilder.h>

Are TextRun.h and StringBuilder.h needed?
Comment 5 yosin 2012-09-02 19:05:56 PDT 
(In reply to comment #4)
> (From update of attachment 161852 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161852&action=review
> 
> > Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:35
> > +#include "TextRun.h"
> > +#include <wtf/text/StringBuilder.h>
> 
> Are TextRun.h and StringBuilder.h needed?
TextRun.h is needed for style()->font().width().
StringBuilder.h isn't needed.
Comment 6 yosin 2012-09-02 19:06:09 PDT 
Created attachment 161854 [details]
Patch 3
Comment 7 yosin 2012-09-02 19:07:25 PDT 
Comment on attachment 161854 [details]
Patch 3

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Remove extra include file StringBuilder.h from DateTimeSymbolicFieldElement.cpp
Comment 8 Kent Tamura 2012-09-02 20:04:21 PDT 
Comment on attachment 161854 [details]
Patch 3

ok
Comment 9 yosin 2012-09-02 21:02:52 PDT 
Comment on attachment 161854 [details]
Patch 3

Clearing flags on attachment: 161854

Committed r127398: <http://trac.webkit.org/changeset/127398>
Comment 10 yosin 2012-09-02 21:02:57 PDT 
All reviewed patches have been landed.  Closing bug.