Bug 95525

Summary: [Forms] Blur from field should reset typeahead buffer in multiple fields time input UI
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 95168    
Bug Blocks:    
Attachments:
Description Flags
Patch 1
none
Patch 2 none

yosin
Reported 2012-08-30 20:38:08 PDT
When following scenario in one second, we expect the value is "00:02:34" but actual value is "00:12:34". 1. Move focus to minute field in <input type="time" value="00:00:34"> 2. Type "1" to set value "00:01:34" 3. Hit Tab key to move focus to second field 4. Hit Shift+Tab key to move focus to minute field 5. Type "2"
Attachments
Patch 1 (5.60 KB, patch)
2012-08-30 21:39 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (5.63 KB, patch)
2012-08-30 21:58 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-08-30 21:39:30 PDT
Created attachment 161617 [details] Patch 1
yosin
Comment 2 2012-08-30 21:40:09 PDT
Comment on attachment 161617 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-08-30 21:44:52 PDT
Comment on attachment 161617 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=161617&action=review > Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:78 > +void DateTimeNumericFieldElement::didBlur() > +{ > + m_lastDigitCharTime = 0; > +} should call DateTimeFieldElement::didBlur().
yosin
Comment 4 2012-08-30 21:58:24 PDT
Created attachment 161618 [details] Patch 2
yosin
Comment 5 2012-08-30 21:59:55 PDT
Comment on attachment 161618 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Added to call DateTimeFieldElement::didBlur() in DateTimeNumericFieldElement::didBlur()
Kent Tamura
Comment 6 2012-08-30 23:20:16 PDT
Comment on attachment 161618 [details] Patch 2 ok
yosin
Comment 7 2012-08-30 23:31:15 PDT
Comment on attachment 161618 [details] Patch 2 Clearing flags on attachment: 161618 Committed r127234: <http://trac.webkit.org/changeset/127234>
yosin
Comment 8 2012-08-30 23:31:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.