Bug 95482

Summary: JSC: Render unto #ifdef's that which belong to them
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix.
fpizlo: review+, gyuyoung.kim: commit-queue-
Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case. none

Mark Lam
Reported 2012-08-30 11:10:56 PDT
Refining / disambiguating between #ifdefs and adding some. For example, ENABLE(JIT) is conflated with ENABLE(LLINT) in some places. Also, we need to add ENABLE(COMPUTED_GOTO_OPCODES) to indicate that we want interpreted opcodes to use COMPUTED GOTOs apart from ENABLE(LLINT) and ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER). Also cleaned up #ifdefs in certain places which were previously incorrect. With current build configurations, this change does not make much difference. But we'll need this later for the LLInt C loop.
Attachments
Fix. (27.46 KB, patch)
2012-08-30 11:26 PDT, Mark Lam 		fpizlo: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case. (27.50 KB, patch)
2012-08-30 13:49 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2012-08-30 11:26:54 PDT
Created attachment 161522 [details] Fix.
Gyuyoung Kim
Comment 2 2012-08-30 12:42:58 PDT
Comment on attachment 161522 [details] Fix. Attachment 161522 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13703008
Early Warning System Bot
Comment 3 2012-08-30 12:46:21 PDT
Comment on attachment 161522 [details] Fix. Attachment 161522 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13681805
Early Warning System Bot
Comment 4 2012-08-30 13:24:14 PDT
Comment on attachment 161522 [details] Fix. Attachment 161522 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13687805
Mark Lam
Comment 5 2012-08-30 13:49:15 PDT
Created attachment 161548 [details] Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case. I missed the case where someone may want to build the classic interpreter without compute gotos even when HAVE(COMPUTED_GOTO) is defined. Anyway, this is now fixed by not enabling ENABLE(COMPUTED_GOTO_OPCODES) when !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER).
WebKit Review Bot
Comment 6 2012-08-30 15:21:26 PDT
Comment on attachment 161548 [details] Fix HAVE(COMPUTED_GOTO) && !ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER) case. Clearing flags on attachment: 161548 Committed r127199: <http://trac.webkit.org/changeset/127199>
WebKit Review Bot
Comment 7 2012-08-30 15:21:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.