Bug 95469

Summary: [BlackBerry] Implement IncrementalSweeper for PLATFORM(BLACKBERRY)
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch
none
the patch none

Yong Li
Reported 2012-08-30 09:36:34 PDT
as we have the HeapTimer implemented
Attachments
the patch (3.47 KB, patch)
2012-08-30 09:43 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
the patch (3.61 KB, patch)
2012-08-30 09:52 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2012-08-30 09:43:20 PDT
Created attachment 161496 [details] the patch It shares most code with USE(CF). But I have to change CFTimeInterval to double. Geoffrey, is that OK?
Yong Li
Comment 2 2012-08-30 09:52:55 PDT
Created attachment 161500 [details] the patch
Rob Buis
Comment 3 2012-08-30 10:16:20 PDT
Comment on attachment 161500 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=161500&action=review > Source/JavaScriptCore/heap/IncrementalSweeper.cpp:106 > + double elapsedTime = WTF::monotonicallyIncreasingTime() - sweepBeginTime; This patch looks good to me, Yong said he took double over CFTimeInterval here since all methods used return double's. Maybe some Apple folks can comment whether CFTimeInterval usage is absolutely needed here?
Rob Buis
Comment 4 2012-08-30 13:36:46 PDT
Comment on attachment 161500 [details] the patch LGTM.
WebKit Review Bot
Comment 5 2012-08-30 13:50:16 PDT
Comment on attachment 161500 [details] the patch Clearing flags on attachment: 161500 Committed r127185: <http://trac.webkit.org/changeset/127185>
WebKit Review Bot
Comment 6 2012-08-30 13:50:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.