Bug 95456

Summary:

Web Inspector: render box model elements and grid on inspector overlay

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, peter+ews, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] with patch applied	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	vsevik: review+

Pavel Feldman

Reported 2012-08-30 07:12:53 PDT

This change migrates native rendering for box model to the InspectorOverlay.

Attachments
[IMAGE] with patch applied (119.57 KB, image/png) 2012-08-30 07:27 PDT, Pavel Feldman	no flags	Details
Patch (46.02 KB, patch) 2012-08-30 07:27 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (46.47 KB, patch) 2012-08-30 08:11 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (46.51 KB, patch) 2012-08-30 08:56 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (47.53 KB, patch) 2012-08-31 01:36 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (47.55 KB, patch) 2012-08-31 01:54 PDT, Pavel Feldman	vsevik: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-08-30 07:27:10 PDT

Created attachment 161464 [details] [IMAGE] with patch applied

Pavel Feldman

Comment 2 2012-08-30 07:27:35 PDT

Created attachment 161465 [details] Patch

Peter Beverloo (cr-android ews)

Comment 3 2012-08-30 07:41:46 PDT

Comment on attachment 161465 [details] Patch Attachment 161465 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13681701

Build Bot

Comment 4 2012-08-30 07:44:29 PDT

Comment on attachment 161465 [details] Patch Attachment 161465 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13684716

Pavel Feldman

Comment 5 2012-08-30 08:11:49 PDT

Created attachment 161473 [details] Patch

Build Bot

Comment 6 2012-08-30 08:26:25 PDT

Comment on attachment 161473 [details] Patch Attachment 161473 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13688768

Peter Beverloo (cr-android ews)

Comment 7 2012-08-30 08:34:42 PDT

Comment on attachment 161473 [details] Patch Attachment 161473 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13684726

Pavel Feldman

Comment 8 2012-08-30 08:56:19 PDT

Created attachment 161484 [details] Patch

Peter Beverloo (cr-android ews)

Comment 9 2012-08-30 09:15:39 PDT

Comment on attachment 161484 [details] Patch Attachment 161484 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13688779

Vsevolod Vlasov

Comment 10 2012-08-31 01:29:00 PDT

Comment on attachment 161484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161484&action=review > Source/WebCore/inspector/InspectorOverlay.cpp:48 > +#include "RenderView.h" Not needed ? > Source/WebCore/inspector/InspectorOverlay.cpp:393 > { Maybe if (m_pausedInDebuggerMessage.isEmpty()) return ? > Source/WebCore/inspector/InspectorOverlay.cpp:425 > +#if OS(WINDOWS) Move this checks in InspectorOverlayPage.html ? > Source/WebCore/inspector/InspectorOverlay.cpp:426 > +overlaySettings->setDefaultFontSize(12); indent > Source/WebCore/inspector/InspectorOverlay.h:34 > +#include "InspectorValues.h" is that needed? > Source/WebCore/inspector/InspectorOverlayPage.html:84 > +function takeLast(array) array.pop()

Pavel Feldman

Comment 11 2012-08-31 01:36:16 PDT

Created attachment 161637 [details] Patch

Pavel Feldman

Comment 12 2012-08-31 01:36:58 PDT

> Not needed ? > Done. > Maybe > if (m_pausedInDebuggerMessage.isEmpty()) > return Done. > > Source/WebCore/inspector/InspectorOverlay.cpp:425 > > +#if OS(WINDOWS) > > Move this checks in InspectorOverlayPage.html ? Done. > > > Source/WebCore/inspector/InspectorOverlay.cpp:426 > > +overlaySettings->setDefaultFontSize(12); > > indent Done. > > > Source/WebCore/inspector/InspectorOverlay.h:34 > > +#include "InspectorValues.h" > > is that needed? Done. > > > Source/WebCore/inspector/InspectorOverlayPage.html:84 > > +function takeLast(array) > > array.pop()

Peter Beverloo (cr-android ews)

Comment 13 2012-08-31 01:48:25 PDT

Comment on attachment 161637 [details] Patch Attachment 161637 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13722071

Pavel Feldman

Comment 14 2012-08-31 01:54:21 PDT

Created attachment 161639 [details] Patch

Pavel Feldman

Comment 15 2012-08-31 02:35:38 PDT

Committed r127240: <http://trac.webkit.org/changeset/127240>

Note You need to log in before you can comment on or make changes to this bug.