| Summary: | [NRWT] Add support for recognizing arbitrary process names in crash lines | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||
| Component: | New Bugs | Assignee: | jochen | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dpranke, ojan, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
jochen
2012-08-30 01:19:46 PDT
Created attachment 161424 [details]
Patch
Comment on attachment 161424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161424&action=review > Tools/Scripts/webkitpy/layout_tests/port/driver.py:313 > + m = re.match('#(?:CRASHED|PROCESS UNRESPONSIVE) - (\S+)', error_line) Can we use a variable name that's more descriptive than "m" ? > Tools/Scripts/webkitpy/layout_tests/port/driver.py:317 > + if m: > + self._crashed_process_name = m.group(1) > + else: > + self._crashed_process_name = 'WebProcess' This really wants to be a ternary expression. Created attachment 161426 [details]
Patch for landing
Comment on attachment 161426 [details] Patch for landing Clearing flags on attachment: 161426 Committed r127122: <http://trac.webkit.org/changeset/127122> All reviewed patches have been landed. Closing bug. |