Bug 95395

Summary: [Chromium] The CC button is not painted
Product: WebKit Reporter: Victor Carbune <vcarbune>
Component: MediaAssignee: Victor Carbune <vcarbune>
Status: RESOLVED FIXED    
Severity: Normal CC: annacc, eric.carlson, eric, feature-media-reviews, silviapf, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 84672    
Attachments:
Description Flags
Fix
none
Fixed minor issue none

Description Victor Carbune 2012-08-29 15:58:52 PDT 
The actual resource for the closed caption button needs to be used and painted.
Comment 1 Victor Carbune 2012-08-29 16:12:46 PDT 
Created attachment 161348 [details]
Fix
Comment 2 Victor Carbune 2012-08-30 03:20:58 PDT 
Created attachment 161434 [details]
Fixed minor issue
Comment 3 Victor Carbune 2012-08-30 03:22:19 PDT 
Comment on attachment 161348 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=161348&action=review

> Source/WebCore/rendering/RenderMediaControlsChromium.cpp:374
>      case MediaShowClosedCaptionsButton:

Sorry, this was faulty as the switch case statement above were falling through. Fixed.
Comment 4 Gyuyoung Kim 2012-08-30 03:27:39 PDT 
Comment on attachment 161434 [details]
Fixed minor issue

Attachment 161434 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13689633
Comment 5 Victor Carbune 2012-08-30 06:16:42 PDT 
(In reply to comment #4)
> (From update of attachment 161434 [details])
> Attachment 161434 [details] did not pass efl-ews (efl):
> Output: http://queues.webkit.org/results/13689633
Hmm, I don't think this break is caused by my patch.
Comment 6 Eric Carlson 2012-08-30 10:29:40 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 161434 [details] [details])
> > Attachment 161434 [details] [details] did not pass efl-ews (efl):
> > Output: http://queues.webkit.org/results/13689633
> Hmm, I don't think this break is caused by my patch.

I agree. Clearing cq-.
Comment 7 WebKit Review Bot 2012-08-30 11:52:38 PDT 
Comment on attachment 161434 [details]
Fixed minor issue

Clearing flags on attachment: 161434

Committed r127168: <http://trac.webkit.org/changeset/127168>
Comment 8 WebKit Review Bot 2012-08-30 11:52:41 PDT 
All reviewed patches have been landed.  Closing bug.