Summary: | [Chromium] The CC button is not painted | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Victor Carbune <vcarbune> | ||||||
Component: | Media | Assignee: | Victor Carbune <vcarbune> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annacc, eric.carlson, eric, feature-media-reviews, silviapf, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 84672 | ||||||||
Attachments: |
|
Description
Victor Carbune
2012-08-29 15:58:52 PDT
Created attachment 161348 [details]
Fix
Created attachment 161434 [details]
Fixed minor issue
Comment on attachment 161348 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=161348&action=review > Source/WebCore/rendering/RenderMediaControlsChromium.cpp:374 > case MediaShowClosedCaptionsButton: Sorry, this was faulty as the switch case statement above were falling through. Fixed. Comment on attachment 161434 [details] Fixed minor issue Attachment 161434 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13689633 (In reply to comment #4) > (From update of attachment 161434 [details]) > Attachment 161434 [details] did not pass efl-ews (efl): > Output: http://queues.webkit.org/results/13689633 Hmm, I don't think this break is caused by my patch. (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 161434 [details] [details]) > > Attachment 161434 [details] [details] did not pass efl-ews (efl): > > Output: http://queues.webkit.org/results/13689633 > Hmm, I don't think this break is caused by my patch. I agree. Clearing cq-. Comment on attachment 161434 [details] Fixed minor issue Clearing flags on attachment: 161434 Committed r127168: <http://trac.webkit.org/changeset/127168> All reviewed patches have been landed. Closing bug. |